Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: restructured the client classes, agent verbs #10834

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Added some extra ways to provide functions to the models, and allow more things to be set in the client constructor, rather then the call that get's called by the async context manager.

Description

  • This also splits the backend classes into a new file called _open_ai_realtime.py keeping only the public classes available in the open_ai_realtime.py file.
  • Adds additional ways of setting up
  • Adds usage of model_extra to set things up in the constructor

Contribution Checklist

Sorry, something went wrong.

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner March 6, 2025 14:04
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Mar 6, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 6, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai
   realtime_client_base.py36197%120
semantic_kernel/connectors/ai/open_ai/services
   _open_ai_realtime.py43013968%268–275, 350, 358, 402–406, 430–433, 524–525, 528–529, 532–536, 539, 547–550, 557, 559, 562–563, 613–616, 625–628, 640–641, 680, 686–694, 704–748, 754–755, 758–759, 763–793, 801–810, 814–833, 854, 857, 860–870, 873–879
   azure_realtime.py29872%90–105, 123
   open_ai_realtime.py37684%100–101, 103, 179–180, 182
semantic_kernel/services
   ai_service_client_base.py22195%64
TOTAL19639257287% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3208 5 💤 0 ❌ 0 🔥 1m 34s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Mar 6, 2025
Merged via the queue into microsoft:main with commit b4456aa Mar 6, 2025
28 checks passed
@eavanvalkenburg eavanvalkenburg deleted the realtime_tweaks branch March 6, 2025 19:32
musale pushed a commit to musale/semantic-kernel that referenced this pull request Mar 10, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Added some extra ways to provide functions to the models, and allow more
things to be set in the client constructor, rather then the __call__
that get's called by the async context manager.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
- This also splits the backend classes into a new file called
_open_ai_realtime.py keeping only the public classes available in the
open_ai_realtime.py file.
- Adds additional ways of setting up
- Adds usage of model_extra to set things up in the constructor

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants