-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: restructured the client classes, agent verbs #10834
Merged
eavanvalkenburg
merged 4 commits into
microsoft:main
from
eavanvalkenburg:realtime_tweaks
Mar 6, 2025
Merged
Python: restructured the client classes, agent verbs #10834
eavanvalkenburg
merged 4 commits into
microsoft:main
from
eavanvalkenburg:realtime_tweaks
Mar 6, 2025
+1,018
−941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Test Coverage Report •
Python Unit Test Overview
|
alliscode
approved these changes
Mar 6, 2025
3c10b35
to
fdbc5f0
Compare
TaoChenOSU
reviewed
Mar 6, 2025
python/samples/concepts/realtime/realtime_agent_with_function_calling_websocket.py
Show resolved
Hide resolved
python/samples/concepts/realtime/realtime_agent_with_function_calling_webrtc.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/open_ai/services/_open_ai_realtime.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
approved these changes
Mar 6, 2025
musale
pushed a commit
to musale/semantic-kernel
that referenced
this pull request
Mar 10, 2025
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Added some extra ways to provide functions to the models, and allow more things to be set in the client constructor, rather then the __call__ that get's called by the async context manager. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - This also splits the backend classes into a new file called _open_ai_realtime.py keeping only the public classes available in the open_ai_realtime.py file. - Adds additional ways of setting up - Adds usage of model_extra to set things up in the constructor ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added some extra ways to provide functions to the models, and allow more things to be set in the client constructor, rather then the call that get's called by the async context manager.
Description
Contribution Checklist