-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Bug: Process Framework KernelProcessStep.on_activate is never called #9829
Comments
@eavanvalkenburg - can you take a look? |
@Druid-of-Luhn - thanks for reporting this! |
4 tasks
@Druid-of-Luhn thanks for calling this out, turns out that was a leftover from a previous iteration, it was surpassed by the |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 29, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Removes an outdated function `on_activate` from the KernelProcessStep class and the one place it was overridden. Fixes #9829 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Evan Mattson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The abstract class
KernelProcessStep
has anon_activate
method, which one would assume is called when the step is activated, but the method is never called.To Reproduce
Steps to reproduce the behavior:
KernelProcessStep
subclass that overrides theon_activate
method,on_activate
method is never called.Expected behavior
The
KernelProcessStep.on_activate
method would be called when a step is activated, in both the local and Dapr runtimes. This would act as a form of zero-argument init method for when a step is activated.Screenshots
Result of the code search showing that
on_activate
is never called.Platform
Additional context
n/a
The text was updated successfully, but these errors were encountered: