Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VoiceOver accessibility support for Flatlist #1341

Merged
merged 32 commits into from
Aug 12, 2022

Conversation

chiuam
Copy link

@chiuam chiuam commented Aug 9, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This change improves the VoiceOver accessibility experience in Flatlist by adding support for announcing the row index.
Note: When navigating into the "table" and selecting the first row item, VO announces "No selection" before its label. I couldn't find a good workaround for this unwanted behavior.(Created #1348 for tracking)

Changelog

[macOS] [Fixed] - Improve VoiceOver accessibility support for Flatlist

Test Plan

Before:
VO announces the ScrollView element as scroll area
VO+R is no-op
keyboard focus / VO+fn+3 announces the item label

Before.mov

After:
VO announces the ScrollView element as table
keyboard focus / VO+R announces the item label
VO+fn+3 announces the item label and its index

After.mov

chiuam and others added 23 commits May 19, 2022 17:24
@analysis-bot
Copy link

analysis-bot commented Aug 9, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 6fcfe2e
Branch: main

@chiuam chiuam marked this pull request as ready for review August 9, 2022 18:15
@chiuam chiuam requested a review from a team as a code owner August 9, 2022 18:15
@harrieshin
Copy link

does the flatlist automatically scroll when you change the VO focus on one of the subview?

@chiuam
Copy link
Author

chiuam commented Aug 10, 2022

does the flatlist automatically scroll when you change the VO focus on one of the subview?

Nope, which is bad because it deviates from the native behavior :/
Edit: Created #1347 for tracking

@chiuam chiuam merged commit a019ab9 into microsoft:main Aug 12, 2022
@chiuam chiuam deleted the flatlist-vo-accessibility branch August 12, 2022 15:43
amgleitman pushed a commit to amgleitman/react-native-macos that referenced this pull request Aug 23, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants