forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve VoiceOver accessibility support for Flatlist #1341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base commit: 6fcfe2e |
harrieshin
reviewed
Aug 9, 2022
harrieshin
reviewed
Aug 9, 2022
Saadnajmi
reviewed
Aug 9, 2022
does the flatlist automatically scroll when you change the VO focus on one of the subview? |
Nope, which is bad because it deviates from the native behavior :/ |
Saadnajmi
reviewed
Aug 10, 2022
harrieshin
reviewed
Aug 11, 2022
Saadnajmi
approved these changes
Aug 11, 2022
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Aug 23, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This change improves the VoiceOver accessibility experience in Flatlist by adding support for announcing the row index.
Note: When navigating into the "table" and selecting the first row item, VO announces "No selection" before its label. I couldn't find a good workaround for this unwanted behavior.(Created #1348 for tracking)
Changelog
[macOS] [Fixed] - Improve VoiceOver accessibility support for Flatlist
Test Plan
Before:
VO announces the ScrollView element as scroll area
VO+R is no-op
keyboard focus / VO+fn+3 announces the item label
Before.mov
After:
VO announces the ScrollView element as table
keyboard focus / VO+R announces the item label
VO+fn+3 announces the item label and its index
After.mov