Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message in position.py #922

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Fix error message in position.py #922

merged 2 commits into from
Mar 6, 2022

Conversation

cuicorey
Copy link
Contributor

Description

Correct the error message when stock amount < trade amount

Motivation and Context

How Has This Been Tested?

<! --- Put an x in all the boxes that apply: --->

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Feb 18, 2022

Please fix the CI error

@cuicorey
Update position.py
fffe73e 
fix CI error
@you-n-g you-n-g merged commit 2ac964c into microsoft:main Mar 6, 2022
@cuicorey cuicorey deleted the update_position branch March 7, 2022 02:44
@you-n-g you-n-g added the enhancement New feature or request label Mar 8, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@cuicorey
Fix error message in position.py (microsoft#922)
aff00ca 
* Update position.py

* Update position.py

fix CI error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuicorey @you-n-g