Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typo in qlib/tests/data.py #179

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Fix some typo in qlib/tests/data.py #179

merged 1 commit into from
Jan 6, 2021

Conversation

fzc621
Copy link
Contributor

@fzc621 fzc621 commented Jan 6, 2021

Description

chuck_size -> chunk_size
unlike -> unlink

Motivation and Context

The second typo will result in some bugs when deleting the downloaded zip file.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

Fix some typo
@you-n-g
Copy link
Collaborator

you-n-g commented Jan 6, 2021

@fzc621 That's great !
Thanks so much!

@you-n-g you-n-g merged commit 4dbc8e5 into microsoft:main Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants