fix typo, staticmethod etc. #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed; 2) no need to use custom numba version for pytest.
github-actions
bot
added
the
waiting for triage
|
Please merge main branch to fix the CI. The CI issue has been fixed in #1398 |
|
It looks great! |
you-n-g
added
documentation
qianyun210603
added a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* config.py: fix typo; static method * fix typo in qlib/utils/paral * 1) limit numpy version as numba support for 1.24+ has not been released; 2) no need to use custom numba version for pytest. * remove useless argument Co-authored-by: you-n-g <[email protected]>
qianyun210603
added a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* config.py: fix typo; static method * fix typo in qlib/utils/paral * 1) limit numpy version as numba support for 1.24+ has not been released; 2) no need to use custom numba version for pytest. * remove useless argument Co-authored-by: you-n-g <[email protected]>
qianyun210603
added a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* config.py: fix typo; static method * fix typo in qlib/utils/paral * 1) limit numpy version as numba support for 1.24+ has not been released; 2) no need to use custom numba version for pytest. * remove useless argument Co-authored-by: you-n-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some typo in code and make some function static as proper
Motivation and Context
improve code quality
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes