Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few mixed Chinese punctuation typos #1123

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

bingyao
Copy link
Contributor

@bingyao bingyao commented Jun 12, 2022

Description

There are a few Chinese punctuations ( and ) mixed inadvertently in codes and docs.

This PR fixed those typos by replacing the fullwidth punctuations with the halfwidth forms.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation
  • Fix typos

@ghost
Copy link

ghost commented Jun 12, 2022

CLA assistant check
All CLA requirements met.

@you-n-g
Copy link
Collaborator

you-n-g commented Jun 14, 2022

Thanks so much! Welcome to become one of Qlib's contributors

@you-n-g you-n-g merged commit 3e6e286 into microsoft:main Jun 14, 2022
@bingyao bingyao deleted the fix_mixed_chinese_punctuation_typos branch June 14, 2022 16:00
@you-n-g you-n-g added the documentation Improvements or additions to documentation label Jun 15, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants