Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type cast build error #23423

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Fix type cast build error #23423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
#include "core/framework/print_tensor_statistics_utils.h"
#include <iomanip>
#include <cctype>
#include <vector>

Check warning on line 11 in onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]

Raw Output:
onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc:11:  Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]
#include <string>
#include <algorithm>

Check warning on line 13 in onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]

Raw Output:
onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc:13:  Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]
#include <utility>

Check warning on line 14 in onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]

Raw Output:
onnxruntime/core/framework/debug_node_inputs_outputs_utils.cc:14:  Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]

#ifdef DEBUG_NODE_INPUTS_OUTPUTS_ENABLE_DUMP_TO_SQLDB
#include <sqlite3.h>
Expand Down
1 change: 1 addition & 0 deletions onnxruntime/core/framework/debug_node_inputs_outputs_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "core/framework/session_state.h"
#include "core/graph/graph.h"
#include <unordered_set>
#include <unordered_map>

Check warning on line 23 in onnxruntime/core/framework/debug_node_inputs_outputs_utils.h

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]

Raw Output:
onnxruntime/core/framework/debug_node_inputs_outputs_utils.h:23:  Found C++ system header after other header. Should be: debug_node_inputs_outputs_utils.h, c system, c++ system, other.  [build/include_order] [4]
#include <mutex>
#include <string>

Expand Down
4 changes: 2 additions & 2 deletions onnxruntime/core/framework/print_tensor_statistics_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ void PrintCommonStats(const T* data, size_t count, TensorStatisticsData& tensor_
// Statistics for float and double only for now.
if constexpr (std::is_same<T, float>::value) {
tensor_statistics.is_float = true;
tensor_statistics.float_min = static_cast<double>(min);
tensor_statistics.float_max = static_cast<double>(max);
tensor_statistics.float_min = static_cast<float>(min);
tensor_statistics.float_max = static_cast<float>(max);
}
}

Expand Down
Loading