Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more log details for source connector #549

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Add more log details for source connector #549

merged 8 commits into from
Feb 28, 2024

Conversation

xinlian12
Copy link
Contributor

@xinlian12 xinlian12 commented Feb 28, 2024 •
edited
Loading

Changes:

  1. Add more debug level logs in source connector
  2. Adding worker name in the userAgent
  3. Fixed NullPointerException when the value of sinkRecord is null in trace log
  4. Close cosmos client properly when sink task is closed
  5. Prepare release of 1.14.0

@xinlian12 xinlian12 requested a review from a team as a code owner February 28, 2024 05:50
simorenoh
simorenoh previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@simorenoh simorenoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick turnaround Annie!

FabianMeiswinkel
FabianMeiswinkel previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabianMeiswinkel FabianMeiswinkel dismissed stale reviews from simorenoh and themself via 1024555 February 28, 2024 12:31
FabianMeiswinkel
FabianMeiswinkel approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinlian12 xinlian12 merged commit 00ee1f0 into microsoft:dev Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@simorenoh simorenoh simorenoh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinlian12 @FabianMeiswinkel @simorenoh @kushagraThapar