-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes parsing for empty arrays #466
Fixes parsing for empty arrays #466
Conversation
9308dde
to
9cd4a5f
Compare
Can anybody have a look at this please? It's a pretty basic bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however, I wouldn't recommend updating the kafka library version as part of this PR. We can do that as part of release when we do it.
@kushagraThapar I'm not sure what update you refer to. I'm not updating the Kafka library version (that's part of Kafka Connect anyway). What I'm upgrading is the version for this library, which I think it's fair since I'm fixing a bug. |
@javierholguera - I am referring to the version of this library (kafka connect cosmos db). |
9cd4a5f
to
5142a88
Compare
@kushagraThapar done |
@javierholguera thanks again for your contribution, we really appreciate it. |
Type of PR
Purpose of PR
Observability + Testing
What changes or considerations did you make in relation to observability?
Did you add testing to account for any new or changed work?
Review notes
Issues Closed or Referenced