Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parsing for empty arrays #466

Merged

Conversation

javierholguera
Copy link
Contributor

@javierholguera javierholguera commented Jul 22, 2022

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

Observability + Testing

  • What changes or considerations did you make in relation to observability?

  • Did you add testing to account for any new or changed work?

Review notes

Issues Closed or Referenced

  • Closes # (this will automatically close the issue when the PR closes)
  • References # (this references the issue but does not close with PR)

@javierholguera javierholguera requested a review from a team as a code owner July 22, 2022 11:54
@ghost
Copy link

ghost commented Jul 22, 2022

CLA assistant check
All CLA requirements met.

@javierholguera javierholguera force-pushed the fix-empty-array-parsing branch from 9308dde to 9cd4a5f Compare July 22, 2022 12:36
@javierholguera
Copy link
Contributor Author

Can anybody have a look at this please? It's a pretty basic bug

Copy link
Collaborator

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I wouldn't recommend updating the kafka library version as part of this PR. We can do that as part of release when we do it.

@javierholguera
Copy link
Contributor Author

@kushagraThapar I'm not sure what update you refer to. I'm not updating the Kafka library version (that's part of Kafka Connect anyway). What I'm upgrading is the version for this library, which I think it's fair since I'm fixing a bug.

@kushagraThapar
Copy link
Collaborator

@javierholguera - I am referring to the version of this library (kafka connect cosmos db).
The reason we don't want to update the version as part of a bug fix is we are not sure whether we will release a hotfix or minor version. That is decided based on a monthly cycle and the changes we do in that particular month.
Since next kafka connect cosmos db release is due soon, I will update the version once we are closer to the release. Hope it makes sense, thanks!

@javierholguera javierholguera force-pushed the fix-empty-array-parsing branch from 9cd4a5f to 5142a88 Compare August 3, 2022 07:46
@javierholguera
Copy link
Contributor Author

@kushagraThapar done

@kushagraThapar
Copy link
Collaborator

@javierholguera thanks again for your contribution, we really appreciate it.
I will merge this PR and this should get released this week as part of our monthly release.

@kushagraThapar kushagraThapar merged commit 940b4b4 into microsoft:dev Aug 3, 2022
@javierholguera javierholguera deleted the fix-empty-array-parsing branch October 5, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants