build(deps): bump golang.org/x/oauth2 from 0.26.0 to 0.27.0 #221
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.26.0 to 0.27.0. - [Commits](golang/oauth2@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
go.mod
Outdated
| @@ -4,6 +4,7 @@ | |||
| module github.com/microsoft/go-infra | |||
|
|
|||
| go 1.22.0 | |||
| toolchain go1.23.6 | |||
There was a problem hiding this comment.
Does the toolchain being > than the go above is correct?
There was a problem hiding this comment.
It could be correct, see this post for more info about how these directives works: https://go.dev/blog/toolchain.
This PR set the toolchain to be go1.23.6 because the new golang.org/x/oauth2 now requires Go 1.23: https://github.com/golang/oauth2/blob/681b4d8edca1bcfea5bce685d77ea7b82ed3e7b3/go.mod#L3, which conflicts with our go directives, that sets Go 1.22 as the minimum required version.
The problem is that this go.mod update is wrong. Setting the toolchain directive is almost never needed, if it is omitted it defaults to the go directives, and having just one directive is easier to maintain. In this case, he also need the go directive to be at least go1.23.0, which is what you get when running go mod tidy after bumping the oauth2 module. I don't know why Dependabot didn't touch the go directive, maybe is using an outdated Go version, or it could be implementing this independently.
I'll fix it.
There was a problem hiding this comment.
Looks like it's a bug tracked by:
- Go directive in go.mod not updated when a new dependency requires it dependabot/dependabot-core#9527
(It seems that conversation got briefly derailed by general toolchain discussion, but the original description and latest reply describe this problem.)
Bumps golang.org/x/oauth2 from 0.26.0 to 0.27.0.
Commits
681b4d8jws: split token into fixed number of parts3f78298all: upgrade go directive to at least 1.23.0 [generated]109dabfendpoints: add links/provider for Discordac571faoauth2: fix docs for Config.DeviceAuth314ee5bendpoints: add patreon endpointDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)