Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore should ignore downloaded files of sample 08-building-search-applications #536

Closed
merklbe1SICKAG opened this issue Jul 26, 2024 · 2 comments
Assignees

Comments

@merklbe1SICKAG
Copy link

Describe the bug
in sample 08-building-search-applications the script (transcript_download.py) downloads data from youtube and stores is in subdirectory within the sample. However this is data which does not belong to the version control, hence there should be an entry in .gitignore.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 08-building-search-applications
  2. build the example, download dependencies with pip etc
  3. start the example via the prepare_transcripts_ai_show.sh
  4. this downloads file to 08-building-search-applications/scripts/transcripts_the_ai_show/
  5. git shows the downloaded files as U, however they should be ignored

Expected behavior
downloaded files should be ignored in git.

Copy link

👋 Thanks for contributing @merklbe1SICKAG! We will review the issue and get back to you soon.

@koreyspace
Copy link
Collaborator

Thanks for reporting and the PR. I have tagged @gloveboxes to review as the lesson owner.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants