Code Refactor for Replication/Migration #962

vazois · 2025-01-27T17:55:53Z

This PR includes the following changes (in preparation for the diskless replication PR):

Refactor replication tests to a separate folder to make addition of new tests withe custom server setup parameters easier.
Refactor migration GarnetClientSession extension to allow for re-use of the same pattern with diskless-repl.
Add OneWriteLock method to support non-blocking writeLock acquisition for diskless-repl.
Check if AOF sync started when disposing AofSyncTaskInfo to avoid GCS not being disposed when background sync has not started.

vazois force-pushed the vazois/code-refactor branch 4 times, most recently from 46a8be8 to 351b051 Compare January 28, 2025 18:08

TalZaccai requested a review from badrishc January 28, 2025 19:09

badrishc approved these changes Jan 28, 2025

View reviewed changes

vazois force-pushed the vazois/code-refactor branch 2 times, most recently from bf3b348 to c10515e Compare January 29, 2025 23:17

vazois added 7 commits January 29, 2025 15:48

refactor/cleanup replication tests

c24332d

refactor/cleanup migration iterative network send

cbbd009

add OneWriteLock

19ed687

fix migrate progress flag

dc88107

dispose gcs when background sync has not started

8b66021

make test fixture nonparallelizable

122c654

use try write lock for dipose of GCS in AofSyncTask

c988074

vazois force-pushed the vazois/code-refactor branch from c10515e to c988074 Compare January 29, 2025 23:48

vazois merged commit f365c94 into microsoft:main Jan 30, 2025
15 checks passed

Provide feedback