Infer from annotated return type nodes before assigning contextual parameter types #60964

Andarist · 2025-01-13T07:39:27Z

It doesn't fix any of those issues but it addresses the gotcha observed in both threads, see #60922 (comment) and #60544 (comment)

…rameter types

typescript-bot · 2025-01-13T07:39:32Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Harpush · 2025-02-17T23:26:48Z

Any chance this PR lands?

jakebailey · 2025-02-20T00:42:07Z

This feels right to me; the info is right there after all.

@typescript-bot test it

typescript-bot · 2025-02-20T00:42:12Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-20T01:12:02Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-20T01:42:07Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,831k (± 1.02%)}	_{193,499k (± 0.74%)}	_~	_192,884k	_196,426k	_{p=0.199 n=6}
_{Parse Time}	_{1.31s (± 0.75%)}	_{1.31s (± 0.94%)}	_~	_1.29s	_1.32s	_{p=0.718 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.74s (± 0.55%)}	_{9.75s (± 0.29%)}	_~	_9.71s	_9.78s	_{p=0.871 n=6}
_{Emit Time}	_{2.73s (± 0.78%)}	_{2.72s (± 0.31%)}	_~	_2.70s	_2.72s	_{p=0.277 n=6}
_{Total Time}	_{14.51s (± 0.39%)}	_{14.50s (± 0.17%)}	_~	_14.47s	_14.53s	_{p=0.422 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,336k (± 0.00%)}	_{1,224,268k (± 0.00%)}	_{-68k (- 0.01%)}	_1,224,216k	_1,224,305k	_{p=0.044 n=6}
_{Parse Time}	_{8.04s (± 0.72%)}	_{8.03s (± 0.60%)}	_~	_7.94s	_8.07s	_{p=0.326 n=6}
_{Bind Time}	_{2.29s (± 0.86%)}	_{2.28s (± 0.33%)}	_~	_2.27s	_2.29s	_{p=0.357 n=6}
_{Check Time}	_{38.02s (± 0.25%)}	_{37.84s (± 0.26%)}	_{-0.18s (- 0.47%)}	_37.71s	_37.93s	_{p=0.020 n=6}
_{Emit Time}	_{18.33s (± 0.42%)}	_{18.26s (± 0.42%)}	_~	_18.16s	_18.35s	_{p=0.149 n=6}
_{Total Time}	_{66.67s (± 0.21%)}	_{66.41s (± 0.26%)}	_{-0.26s (- 0.39%)}	_66.16s	_66.61s	_{p=0.044 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,347,891	_2,347,891	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,644	_845,644	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,472k (± 0.01%)}	_{2,120,500k (± 0.00%)}	_~	_2,120,364k	_2,120,622k	_{p=0.521 n=6}
_{Parse Time}	_{8.88s (± 1.93%)}	_{8.78s (± 0.56%)}	_~	_8.71s	_8.84s	_{p=0.108 n=6}
_{Bind Time}	_{2.84s (± 7.79%)}	_{2.95s (± 0.69%)}	_~	_2.92s	_2.98s	_{p=0.081 n=6}
_{Check Time}	_{87.93s (± 2.76%)}	_{86.88s (± 0.27%)}	_~	_86.55s	_87.09s	_{p=0.575 n=6}
_{Emit Time}	_{0.20s (± 7.40%)}	_{0.20s (± 7.06%)}	_~	_0.18s	_0.22s	_{p=0.805 n=6}
_{Total Time}	_{99.86s (± 2.37%)}	_{98.80s (± 0.23%)}	_~	_98.45s	_99.02s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,510	_1,228,513	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,847,207k (±13.20%)}	_{2,847,040k (±13.20%)}	_~	_2,360,772k	_3,090,309k	_{p=0.810 n=6}
_{Parse Time}	_{6.65s (± 1.57%)}	_{6.64s (± 1.48%)}	_~	_6.50s	_6.73s	_{p=0.873 n=6}
_{Bind Time}	_{2.15s (± 2.21%)}	_{2.15s (± 1.52%)}	_~	_2.11s	_2.19s	_{p=0.810 n=6}
_{Check Time}	_{42.65s (± 0.73%)}	_{42.55s (± 0.26%)}	_~	_42.47s	_42.75s	_{p=0.471 n=6}
_{Emit Time}	_{3.46s (± 1.76%)}	_{3.40s (± 2.23%)}	_~	_3.29s	_3.51s	_{p=0.230 n=6}
_{Total Time}	_{54.93s (± 0.67%)}	_{54.77s (± 0.38%)}	_~	_54.58s	_55.03s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,510	_1,228,513	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,425,763k (± 0.01%)}	_{2,425,995k (± 0.02%)}	_~	_2,425,396k	_2,426,523k	_{p=0.378 n=6}
_{Parse Time}	_{5.49s (± 0.69%)}	_{5.50s (± 0.41%)}	_~	_5.46s	_5.52s	_{p=0.521 n=6}
_{Bind Time}	_{1.80s (± 2.01%)}	_{1.79s (± 1.44%)}	_~	_1.77s	_1.82s	_{p=0.935 n=6}
_{Check Time}	_{35.29s (± 0.21%)}	_{35.29s (± 0.09%)}	_~	_35.26s	_35.34s	_{p=0.936 n=6}
_{Emit Time}	_{3.02s (± 1.11%)}	_{3.02s (± 2.03%)}	_~	_2.97s	_3.12s	_{p=0.748 n=6}
_{Total Time}	_{45.60s (± 0.16%)}	_{45.60s (± 0.21%)}	_~	_45.48s	_45.73s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,816	_262,819	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,833	_106,833	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,309k (± 0.01%)}	_{440,292k (± 0.01%)}	_~	_440,219k	_440,380k	_{p=0.470 n=6}
_{Parse Time}	_{2.88s (± 0.65%)}	_{2.90s (± 0.34%)}	_~	_2.89s	_2.91s	_{p=0.118 n=6}
_{Bind Time}	_1.11s	_1.11s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.76s (± 0.42%)}	_{15.78s (± 0.37%)}	_~	_15.69s	_15.83s	_{p=0.748 n=6}
_{Emit Time}	_{1.28s (± 1.18%)}	_{1.27s (± 1.44%)}	_~	_1.25s	_1.30s	_{p=0.623 n=6}
_{Total Time}	_{21.03s (± 0.30%)}	_{21.06s (± 0.31%)}	_~	_20.96s	_21.13s	_{p=0.469 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,356k (± 0.02%)}	_{371,352k (± 0.02%)}	_~	_371,276k	_371,476k	_{p=0.810 n=6}
_{Parse Time}	_{2.91s (± 1.13%)}	_{2.89s (± 0.64%)}	_~	_2.86s	_2.91s	_{p=0.292 n=6}
_{Bind Time}	_{1.60s (± 1.00%)}	_{1.60s (± 2.54%)}	_~	_1.57s	_1.68s	_{p=0.199 n=6}
_{Check Time}	_{16.46s (± 0.24%)}	_{16.47s (± 0.23%)}	_~	_16.43s	_16.54s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.36%)}	_{20.96s (± 0.22%)}	_~	_20.91s	_21.03s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,220,984	_3,220,984	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,092,532	_1,092,533	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,296,383k (± 0.01%)}	_{3,296,314k (± 0.01%)}	_~	_3,295,920k	_3,296,720k	_{p=0.471 n=6}
_{Parse Time}	_{14.36s (± 0.71%)}	_{14.27s (± 0.40%)}	_~	_14.20s	_14.36s	_{p=0.148 n=6}
_{Bind Time}	_{4.58s (± 0.65%)}	_{4.61s (± 0.60%)}	_~	_4.57s	_4.64s	_{p=0.147 n=6}
_{Check Time}	_{89.63s (± 1.29%)}	_{87.99s (± 0.62%)}	_{-1.63s (- 1.82%)}	_87.35s	_88.87s	_{p=0.020 n=6}
_{Emit Time}	_{26.79s (± 6.64%)}	_{26.04s (± 8.84%)}	_~	_22.98s	_27.63s	_{p=0.630 n=6}
_{Total Time}	_{135.36s (± 1.82%)}	_{132.91s (± 1.56%)}	_~	_129.76s	_134.75s	_{p=0.066 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,866	_293,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,617	_119,617	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,146k (± 0.02%)}	_{447,193k (± 0.02%)}	_~	_447,071k	_447,308k	_{p=0.230 n=6}
_{Parse Time}	_{4.10s (± 0.83%)}	_{4.09s (± 0.59%)}	_~	_4.07s	_4.13s	_{p=0.514 n=6}
_{Bind Time}	_{1.76s (± 1.42%)}	_{1.76s (± 1.27%)}	_~	_1.73s	_1.79s	_{p=0.627 n=6}
_{Check Time}	_{18.74s (± 0.27%)}	_{18.76s (± 0.24%)}	_~	_18.72s	_18.84s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.62s (± 0.31%)}	_{24.60s (± 0.13%)}	_~	_24.55s	_24.64s	_{p=0.747 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_558,084	_558,084	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,415	_186,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{495,035k (± 0.01%)}	_{494,974k (± 0.02%)}	_~	_494,808k	_495,111k	_{p=0.378 n=6}
_{Parse Time}	_{3.42s (± 0.40%)}	_{3.42s (± 0.34%)}	_~	_3.41s	_3.44s	_{p=0.325 n=6}
_{Bind Time}	_{1.19s (± 1.27%)}	_{1.19s (± 1.06%)}	_~	_1.18s	_1.21s	_{p=1.000 n=6}
_{Check Time}	_{19.59s (± 0.34%)}	_{19.80s (± 2.38%)}	_~	_19.45s	_20.58s	_{p=0.873 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.20s (± 0.28%)}	_{24.41s (± 1.92%)}	_~	_24.06s	_25.18s	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-20T01:42:50Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60964/merge:

Everything looks good!

typescript-bot · 2025-02-20T02:49:14Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60964/merge:

Everything looks good!

jakebailey · 2025-02-21T23:26:21Z

Wait, was this effectively #56460 in disguise? Are all of those now fixed?

Andarist · 2025-02-22T08:35:00Z

Wait, was this effectively #56460 in disguise? Are all of those now fixed?

Not quite. This PR here is solely about the return type node and it doesn't change when this function is called. The other PR is solely about annotated parameters and it makes this function called in more places. So yes, there is a code area overlap between both but they are about different things and none of the other issues are fixed by this PR here.

Infer from annotated return type nodes before assigning contextual pa…

5da59b6

…rameter types

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 13, 2025

Andarist mentioned this pull request Jan 13, 2025

Function Generic is unknown if argument has NoInfer<Generic> but returns the Generic #60922

Closed

jakebailey approved these changes Feb 20, 2025

View reviewed changes

jakebailey merged commit 0d01692 into microsoft:main Feb 20, 2025
32 checks passed

jakebailey mentioned this pull request Feb 21, 2025

Infer from annotated parameters of context sensitive functions in the first inference pass #56460

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infer from annotated return type nodes before assigning contextual parameter types #60964

Infer from annotated return type nodes before assigning contextual parameter types #60964

Andarist commented Jan 13, 2025

typescript-bot commented Jan 13, 2025

Harpush commented Feb 17, 2025

jakebailey commented Feb 20, 2025

typescript-bot commented Feb 20, 2025 •

edited

Loading

typescript-bot commented Feb 20, 2025

typescript-bot commented Feb 20, 2025

tsc

typescript-bot commented Feb 20, 2025

typescript-bot commented Feb 20, 2025

jakebailey commented Feb 21, 2025

Andarist commented Feb 22, 2025

Infer from annotated return type nodes before assigning contextual parameter types #60964

Infer from annotated return type nodes before assigning contextual parameter types #60964

Conversation

Andarist commented Jan 13, 2025

typescript-bot commented Jan 13, 2025

Harpush commented Feb 17, 2025

jakebailey commented Feb 20, 2025

typescript-bot commented Feb 20, 2025 • edited Loading

typescript-bot commented Feb 20, 2025

typescript-bot commented Feb 20, 2025

tsc

typescript-bot commented Feb 20, 2025

typescript-bot commented Feb 20, 2025

jakebailey commented Feb 21, 2025

Andarist commented Feb 22, 2025

typescript-bot commented Feb 20, 2025 •

edited

Loading