Remove reference not found errors from jsx: preserve

src/compiler/checker.ts

@@ -30014,14 +30014,15 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             const jsxFactoryRefErr = diagnostics && compilerOptions.jsx === JsxEmit.React ? Diagnostics.This_JSX_tag_requires_0_to_be_in_scope_but_it_could_not_be_found : undefined;
             const jsxFactoryNamespace = getJsxNamespace(node);
             const jsxFactoryLocation = isJsxOpeningLikeElement(node) ? node.tagName : node;
+            const shouldFactoryRefErr = compilerOptions.jsx !== JsxEmit.Preserve && compilerOptions.jsx !== JsxEmit.ReactNative;
 
             // #38720/60122, allow null as jsxFragmentFactory
             let jsxFactorySym: Symbol | undefined;
             if (!(isJsxOpeningFragment(node) && jsxFactoryNamespace === "null")) {
                 jsxFactorySym = resolveName(
                     jsxFactoryLocation,
                     jsxFactoryNamespace,
-                    (compilerOptions.jsx === JsxEmit.Preserve || compilerOptions.jsx === JsxEmit.ReactNative) ? SymbolFlags.Value & ~SymbolFlags.Enum : SymbolFlags.Value,
+                    shouldFactoryRefErr ? SymbolFlags.Value : SymbolFlags.Value & ~SymbolFlags.Enum,
                     jsxFactoryRefErr,
                     /*isUse*/ true,
                 );
@@ -30046,7 +30047,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     resolveName(
                         jsxFactoryLocation,
                         localJsxNamespace,
-                        (compilerOptions.jsx === JsxEmit.Preserve || compilerOptions.jsx === JsxEmit.ReactNative) ? SymbolFlags.Value & ~SymbolFlags.Enum : SymbolFlags.Value,
+                        shouldFactoryRefErr ? SymbolFlags.Value : SymbolFlags.Value & ~SymbolFlags.Enum,
                         jsxFactoryRefErr,
                         /*isUse*/ true,
                     );
@@ -36835,12 +36836,13 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         // #38720/60122, allow null as jsxFragmentFactory
         if (jsxFragmentFactoryName === "null") return sourceFileLinks.jsxFragmentType = anyType;
 
-        const jsxFactoryRefErr = diagnostics ? Diagnostics.Using_JSX_fragments_requires_fragment_factory_0_to_be_in_scope_but_it_could_not_be_found : undefined;
+        const shouldFactoryRefErr = compilerOptions.jsx !== JsxEmit.Preserve && compilerOptions.jsx !== JsxEmit.ReactNative;
+        const jsxFactoryRefErr = diagnostics && shouldFactoryRefErr ? Diagnostics.Using_JSX_fragments_requires_fragment_factory_0_to_be_in_scope_but_it_could_not_be_found : undefined;
         const jsxFactorySymbol = getJsxNamespaceContainerForImplicitImport(node) ??
             resolveName(
                 node,
                 jsxFragmentFactoryName,
-                (compilerOptions.jsx === JsxEmit.Preserve || compilerOptions.jsx === JsxEmit.ReactNative) ? SymbolFlags.Value & ~SymbolFlags.Enum : SymbolFlags.Value,
+                shouldFactoryRefErr ? SymbolFlags.Value : SymbolFlags.Value & ~SymbolFlags.Enum,
                 /*nameNotFoundMessage*/ jsxFactoryRefErr,
                 /*isUse*/ true,
             );

tests/baselines/reference/jsxFragmentFactoryReference(jsx=preserve).js

@@ -0,0 +1,16 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+//// [jsxFragmentFactoryReference.tsx]
+export class LoggedOut {
+    content = () => (
+        <>        </>
+    )
+}
+
+
+//// [jsxFragmentFactoryReference.jsx]
+export class LoggedOut {
+    constructor() {
+        this.content = () => (<>        </>);
+    }
+}

tests/baselines/reference/jsxFragmentFactoryReference(jsx=preserve).symbols

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+=== jsxFragmentFactoryReference.tsx ===
+export class LoggedOut {
+>LoggedOut : Symbol(LoggedOut, Decl(jsxFragmentFactoryReference.tsx, 0, 0))
+
+    content = () => (
+>content : Symbol(LoggedOut.content, Decl(jsxFragmentFactoryReference.tsx, 0, 24))
+
+        <>        </>
+    )
+}
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=preserve).types

@@ -0,0 +1,20 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+=== jsxFragmentFactoryReference.tsx ===
+export class LoggedOut {
+>LoggedOut : LoggedOut
+>          : ^^^^^^^^^
+
+    content = () => (
+>content : () => any
+>        : ^^^^^^^^^
+>() => (        <>        </>    ) : () => any
+>                                  : ^^^^^^^^^
+>(        <>        </>    ) : any
+
+        <>        </>
+><>        </> : any
+
+    )
+}
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react).errors.txt

@@ -0,0 +1,15 @@
+jsxFragmentFactoryReference.tsx(3,9): error TS2874: This JSX tag requires 'React' to be in scope, but it could not be found.
+jsxFragmentFactoryReference.tsx(3,9): error TS2879: Using JSX fragments requires fragment factory 'React' to be in scope, but it could not be found.
+
+
+==== jsxFragmentFactoryReference.tsx (2 errors) ====
+    export class LoggedOut {
+        content = () => (
+            <>        </>
+            ~~
+!!! error TS2874: This JSX tag requires 'React' to be in scope, but it could not be found.
+            ~~
+!!! error TS2879: Using JSX fragments requires fragment factory 'React' to be in scope, but it could not be found.
+        )
+    }
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react).js

@@ -0,0 +1,16 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+//// [jsxFragmentFactoryReference.tsx]
+export class LoggedOut {
+    content = () => (
+        <>        </>
+    )
+}
+
+
+//// [jsxFragmentFactoryReference.js]
+export class LoggedOut {
+    constructor() {
+        this.content = () => (React.createElement(React.Fragment, null, "        "));
+    }
+}

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react).symbols

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+=== jsxFragmentFactoryReference.tsx ===
+export class LoggedOut {
+>LoggedOut : Symbol(LoggedOut, Decl(jsxFragmentFactoryReference.tsx, 0, 0))
+
+    content = () => (
+>content : Symbol(LoggedOut.content, Decl(jsxFragmentFactoryReference.tsx, 0, 24))
+
+        <>        </>
+    )
+}
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react).types

@@ -0,0 +1,22 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+=== jsxFragmentFactoryReference.tsx ===
+export class LoggedOut {
+>LoggedOut : LoggedOut
+>          : ^^^^^^^^^
+
+    content = () => (
+>content : () => any
+>        : ^^^^^^^^^
+>() => (        <>        </>    ) : () => any
+>                                  : ^^^^^^^^^
+>(        <>        </>    ) : any
+>                            : ^^^
+
+        <>        </>
+><>        </> : any
+>              : ^^^
+
+    )
+}
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react-jsx).errors.txt

@@ -0,0 +1,15 @@
+jsxFragmentFactoryReference.tsx(3,9): error TS2792: Cannot find module 'react/jsx-runtime'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
+jsxFragmentFactoryReference.tsx(3,9): error TS2879: Using JSX fragments requires fragment factory 'React' to be in scope, but it could not be found.
+
+
+==== jsxFragmentFactoryReference.tsx (2 errors) ====
+    export class LoggedOut {
+        content = () => (
+            <>        </>
+            ~~
+!!! error TS2792: Cannot find module 'react/jsx-runtime'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
+            ~~
+!!! error TS2879: Using JSX fragments requires fragment factory 'React' to be in scope, but it could not be found.
+        )
+    }
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react-jsx).js

@@ -0,0 +1,17 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+//// [jsxFragmentFactoryReference.tsx]
+export class LoggedOut {
+    content = () => (
+        <>        </>
+    )
+}
+
+
+//// [jsxFragmentFactoryReference.js]
+import { Fragment as _Fragment, jsx as _jsx } from "react/jsx-runtime";
+export class LoggedOut {
+    constructor() {
+        this.content = () => (_jsx(_Fragment, { children: "        " }));
+    }
+}

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react-jsx).symbols

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+=== jsxFragmentFactoryReference.tsx ===
+export class LoggedOut {
+>LoggedOut : Symbol(LoggedOut, Decl(jsxFragmentFactoryReference.tsx, 0, 0))
+
+    content = () => (
+>content : Symbol(LoggedOut.content, Decl(jsxFragmentFactoryReference.tsx, 0, 24))
+
+        <>        </>
+    )
+}
+

tests/baselines/reference/jsxFragmentFactoryReference(jsx=react-jsx).types

@@ -0,0 +1,22 @@
+//// [tests/cases/compiler/jsxFragmentFactoryReference.tsx] ////
+
+=== jsxFragmentFactoryReference.tsx ===
+export class LoggedOut {
+>LoggedOut : LoggedOut
+>          : ^^^^^^^^^
+
+    content = () => (
+>content : () => any
+>        : ^^^^^^^^^
+>() => (        <>        </>    ) : () => any
+>                                  : ^^^^^^^^^
+>(        <>        </>    ) : any
+>                            : ^^^
+
+        <>        </>
+><>        </> : any
+>              : ^^^
+
+    )
+}
+

tests/baselines/reference/jsxRuntimePragma(jsx=preserve).js

@@ -0,0 +1,88 @@
+//// [tests/cases/compiler/jsxRuntimePragma.ts] ////
+
+//// [one.tsx]
+/// <reference path="/.lib/react16.d.ts" />
+/* @jsxRuntime classic */
+import * as React from "react";
+export const HelloWorld = () => <h1>Hello world</h1>;
+export const frag = <><div></div></>;
+export const selfClosing = <img src="./image.png" />;
+//// [two.tsx]
+/// <reference path="/.lib/react16.d.ts" />
+/* @jsxRuntime automatic */
+export const HelloWorld = () => <h1>Hello world</h1>;
+export const frag = <><div></div></>;
+export const selfClosing = <img src="./image.png" />;
+//// [three.tsx]
+/// <reference path="/.lib/react16.d.ts" />
+/* @jsxRuntime classic */
+/* @jsxRuntime automatic */
+export const HelloWorld = () => <h1>Hello world</h1>;
+export const frag = <><div></div></>;
+export const selfClosing = <img src="./image.png" />;
+//// [four.tsx]
+/// <reference path="/.lib/react16.d.ts" />
+/* @jsxRuntime automatic */
+/* @jsxRuntime classic */
+import * as React from "react";
+export const HelloWorld = () => <h1>Hello world</h1>;
+export const frag = <><div></div></>;
+export const selfClosing = <img src="./image.png" />;
+//// [index.ts]
+export * as one from "./one.js";
+export * as two from "./two.js";
+export * as three from "./three.js";
+export * as four from "./four.js";
+
+//// [one.jsx]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.selfClosing = exports.frag = exports.HelloWorld = void 0;
+/// <reference path="react16.d.ts" />
+/* @jsxRuntime classic */
+var React = require("react");
+var HelloWorld = function () { return <h1>Hello world</h1>; };
+exports.HelloWorld = HelloWorld;
+exports.frag = <><div></div></>;
+exports.selfClosing = <img src="./image.png"/>;
+//// [two.jsx]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.selfClosing = exports.frag = exports.HelloWorld = void 0;
+/// <reference path="react16.d.ts" />
+/* @jsxRuntime automatic */
+var HelloWorld = function () { return <h1>Hello world</h1>; };
+exports.HelloWorld = HelloWorld;
+exports.frag = <><div></div></>;
+exports.selfClosing = <img src="./image.png"/>;
+//// [three.jsx]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.selfClosing = exports.frag = exports.HelloWorld = void 0;
+/// <reference path="react16.d.ts" />
+/* @jsxRuntime classic */
+/* @jsxRuntime automatic */
+var HelloWorld = function () { return <h1>Hello world</h1>; };
+exports.HelloWorld = HelloWorld;
+exports.frag = <><div></div></>;
+exports.selfClosing = <img src="./image.png"/>;
+//// [four.jsx]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.selfClosing = exports.frag = exports.HelloWorld = void 0;
+/// <reference path="react16.d.ts" />
+/* @jsxRuntime automatic */
+/* @jsxRuntime classic */
+var React = require("react");
+var HelloWorld = function () { return <h1>Hello world</h1>; };
+exports.HelloWorld = HelloWorld;
+exports.frag = <><div></div></>;
+exports.selfClosing = <img src="./image.png"/>;
+//// [index.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.four = exports.three = exports.two = exports.one = void 0;
+exports.one = require("./one.js");
+exports.two = require("./two.js");
+exports.three = require("./three.js");
+exports.four = require("./four.js");