-
Notifications
You must be signed in to change notification settings - Fork 12.9k
fix: appropriate error message for out of scope label #54927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mvmo
wants to merge
10
commits into
microsoft:main
Choose a base branch
from
Mvmo:feature/improve-error-message-label-not-found
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e931bcc
fix: appropriate error message for out of scope label
Mvmo fb73d53
fix: code style - semicolon
Mvmo 1071d91
New error messages
Mvmo 268c325
remove my code jump comment
Mvmo 612ae78
Update diagnostics
Mvmo 6589870
Add test for label not found case
Mvmo dc23626
Merge branch 'main' into feature/improve-error-message-label-not-found
jakebailey 6194a65
Fix toString
jakebailey 206c10e
Add missing dot
jakebailey e61a99d
Restructure to avoid incorrect errors
jakebailey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
breakTarget7.ts(2,5): error TS18058: Label 'target' used before declaration. | ||
|
||
|
||
==== breakTarget7.ts (1 errors) ==== | ||
function functionContainingBreak() { | ||
break target; | ||
~~~~~~~~~~~~~ | ||
!!! error TS18058: Label 'target' used before declaration. | ||
!!! related TS18059 breakTarget7.ts:3:5: Label defined here | ||
target:; | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
//// [tests/cases/compiler/breakTarget7.ts] //// | ||
|
||
//// [breakTarget7.ts] | ||
function functionContainingBreak() { | ||
break target; | ||
target:; | ||
} | ||
|
||
|
||
//// [breakTarget7.js] | ||
function functionContainingBreak() { | ||
break target; | ||
target: ; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
//// [tests/cases/compiler/breakTarget7.ts] //// | ||
|
||
=== breakTarget7.ts === | ||
function functionContainingBreak() { | ||
>functionContainingBreak : Symbol(functionContainingBreak, Decl(breakTarget7.ts, 0, 0)) | ||
|
||
break target; | ||
target:; | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
//// [tests/cases/compiler/breakTarget7.ts] //// | ||
|
||
=== breakTarget7.ts === | ||
function functionContainingBreak() { | ||
>functionContainingBreak : () => void | ||
> : ^^^^^^^^^^ | ||
|
||
break target; | ||
>target : any | ||
> : ^^^ | ||
|
||
target:; | ||
>target : any | ||
> : ^^^ | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// @allowUnusedLabels: true | ||
function functionContainingBreak() { | ||
break target; | ||
target:; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an effort to try and finish the PR, I've restructured this to avoid the "incorrect" errors.