Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report base primitive sources against boolean targets #38792

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

DanielRosenwasser
Copy link
Member

Expands @JoshuaKGoldberg's #38049 to special-case the bare boolean type.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 26, 2020

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 51d0ec1. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..38792

Metric master 38792 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 328,270k (± 0.04%) 327,849k (± 0.03%) -421k (- 0.13%) 327,588k 328,075k
Parse Time 1.64s (± 0.41%) 1.66s (± 0.58%) +0.01s (+ 0.73%) 1.63s 1.67s
Bind Time 0.90s (± 0.83%) 0.91s (± 0.61%) +0.01s (+ 1.00%) 0.90s 0.92s
Check Time 4.84s (± 0.41%) 4.88s (± 0.67%) +0.04s (+ 0.81%) 4.82s 4.96s
Emit Time 5.43s (± 0.83%) 5.44s (± 1.03%) +0.01s (+ 0.17%) 5.31s 5.60s
Total Time 12.82s (± 0.45%) 12.88s (± 0.65%) +0.07s (+ 0.52%) 12.70s 13.15s
Monaco - node (v10.16.3, x64)
Memory used 327,347k (± 0.01%) 327,346k (± 0.01%) -0k (- 0.00%) 327,265k 327,420k
Parse Time 1.27s (± 0.53%) 1.28s (± 0.73%) +0.00s (+ 0.39%) 1.26s 1.30s
Bind Time 0.78s (± 0.46%) 0.79s (± 0.51%) +0.01s (+ 0.64%) 0.78s 0.80s
Check Time 4.88s (± 0.44%) 4.91s (± 0.40%) +0.03s (+ 0.70%) 4.88s 4.96s
Emit Time 2.95s (± 0.68%) 2.95s (± 0.58%) +0.00s (+ 0.03%) 2.92s 2.99s
Total Time 9.88s (± 0.31%) 9.93s (± 0.27%) +0.04s (+ 0.46%) 9.85s 9.97s
TFS - node (v10.16.3, x64)
Memory used 292,452k (± 0.03%) 292,442k (± 0.02%) -10k (- 0.00%) 292,337k 292,537k
Parse Time 0.97s (± 0.70%) 0.98s (± 0.68%) +0.01s (+ 1.14%) 0.96s 0.99s
Bind Time 0.76s (± 0.73%) 0.76s (± 0.77%) -0.00s (- 0.13%) 0.74s 0.77s
Check Time 4.40s (± 0.69%) 4.40s (± 0.54%) +0.00s (+ 0.02%) 4.34s 4.45s
Emit Time 3.10s (± 0.68%) 3.10s (± 0.85%) +0.01s (+ 0.19%) 3.02s 3.15s
Total Time 9.22s (± 0.48%) 9.23s (± 0.47%) +0.02s (+ 0.16%) 9.12s 9.33s
material-ui - node (v10.16.3, x64)
Memory used 449,971k (± 0.01%) 449,653k (± 0.01%) -318k (- 0.07%) 449,580k 449,780k
Parse Time 1.79s (± 0.27%) 1.79s (± 0.41%) +0.00s (+ 0.28%) 1.78s 1.81s
Bind Time 0.70s (± 1.14%) 0.70s (± 0.57%) -0.00s (- 0.43%) 0.69s 0.71s
Check Time 12.90s (± 0.62%) 12.85s (± 0.96%) -0.05s (- 0.41%) 12.66s 13.24s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.39s (± 0.52%) 15.34s (± 0.86%) -0.05s (- 0.33%) 15.13s 15.76s
Angular - node (v12.1.0, x64)
Memory used 303,832k (± 0.02%) 303,425k (± 0.02%) -407k (- 0.13%) 303,272k 303,543k
Parse Time 1.59s (± 0.56%) 1.60s (± 0.42%) +0.01s (+ 0.50%) 1.59s 1.62s
Bind Time 0.89s (± 1.01%) 0.89s (± 0.67%) 0.00s ( 0.00%) 0.87s 0.90s
Check Time 4.73s (± 0.51%) 4.73s (± 0.22%) -0.00s (- 0.11%) 4.70s 4.75s
Emit Time 5.56s (± 0.65%) 5.53s (± 0.71%) -0.03s (- 0.61%) 5.46s 5.66s
Total Time 12.78s (± 0.44%) 12.74s (± 0.33%) -0.03s (- 0.24%) 12.68s 12.86s
Monaco - node (v12.1.0, x64)
Memory used 307,313k (± 0.02%) 307,317k (± 0.01%) +4k (+ 0.00%) 307,212k 307,420k
Parse Time 1.23s (± 0.74%) 1.24s (± 0.70%) +0.01s (+ 0.73%) 1.22s 1.26s
Bind Time 0.76s (± 0.90%) 0.77s (± 0.64%) +0.01s (+ 1.32%) 0.76s 0.78s
Check Time 4.69s (± 0.41%) 4.71s (± 0.23%) +0.02s (+ 0.43%) 4.70s 4.75s
Emit Time 2.99s (± 0.69%) 3.01s (± 0.69%) +0.02s (+ 0.64%) 2.97s 3.06s
Total Time 9.67s (± 0.31%) 9.72s (± 0.21%) +0.06s (+ 0.58%) 9.68s 9.77s
TFS - node (v12.1.0, x64)
Memory used 274,691k (± 0.02%) 274,679k (± 0.02%) -12k (- 0.00%) 274,590k 274,764k
Parse Time 0.94s (± 0.92%) 0.94s (± 0.71%) -0.00s (- 0.11%) 0.92s 0.95s
Bind Time 0.73s (± 1.02%) 0.73s (± 0.55%) +0.00s (+ 0.14%) 0.72s 0.74s
Check Time 4.30s (± 0.60%) 4.30s (± 0.52%) +0.00s (+ 0.07%) 4.26s 4.36s
Emit Time 3.12s (± 0.66%) 3.13s (± 0.63%) +0.01s (+ 0.35%) 3.09s 3.18s
Total Time 9.09s (± 0.45%) 9.11s (± 0.42%) +0.02s (+ 0.19%) 9.05s 9.20s
material-ui - node (v12.1.0, x64)
Memory used 427,148k (± 0.08%) 427,145k (± 0.01%) -3k (- 0.00%) 427,029k 427,263k
Parse Time 1.77s (± 0.33%) 1.77s (± 0.50%) +0.00s (+ 0.00%) 1.75s 1.79s
Bind Time 0.65s (± 0.92%) 0.65s (± 0.73%) +0.00s (+ 0.15%) 0.64s 0.66s
Check Time 11.50s (± 1.04%) 11.48s (± 0.71%) -0.02s (- 0.20%) 11.30s 11.70s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.91s (± 0.85%) 13.90s (± 0.63%) -0.02s (- 0.12%) 13.70s 14.14s
Angular - node (v8.9.0, x64)
Memory used 323,165k (± 0.02%) 322,784k (± 0.03%) -380k (- 0.12%) 322,633k 323,012k
Parse Time 2.14s (± 0.97%) 2.13s (± 0.41%) -0.01s (- 0.61%) 2.11s 2.15s
Bind Time 0.94s (± 1.01%) 0.94s (± 1.12%) -0.00s (- 0.11%) 0.91s 0.97s
Check Time 5.50s (± 1.58%) 5.54s (± 1.32%) +0.04s (+ 0.75%) 5.34s 5.63s
Emit Time 6.35s (± 1.67%) 6.35s (± 1.38%) +0.00s (+ 0.05%) 6.21s 6.62s
Total Time 14.93s (± 0.43%) 14.96s (± 0.44%) +0.03s (+ 0.18%) 14.83s 15.12s
Monaco - node (v8.9.0, x64)
Memory used 325,977k (± 0.01%) 325,962k (± 0.01%) -15k (- 0.00%) 325,903k 326,068k
Parse Time 1.56s (± 0.51%) 1.56s (± 0.32%) -0.00s (- 0.19%) 1.55s 1.57s
Bind Time 0.91s (± 0.61%) 0.92s (± 0.67%) +0.01s (+ 1.21%) 0.91s 0.93s
Check Time 5.49s (± 0.54%) 5.49s (± 0.55%) -0.00s (- 0.05%) 5.43s 5.55s
Emit Time 3.51s (± 0.58%) 3.48s (± 0.42%) -0.02s (- 0.68%) 3.46s 3.51s
Total Time 11.47s (± 0.42%) 11.45s (± 0.31%) -0.02s (- 0.17%) 11.36s 11.52s
TFS - node (v8.9.0, x64)
Memory used 292,028k (± 0.01%) 292,064k (± 0.01%) +36k (+ 0.01%) 291,993k 292,148k
Parse Time 1.26s (± 0.39%) 1.26s (± 0.49%) -0.00s (- 0.32%) 1.25s 1.28s
Bind Time 0.76s (± 0.73%) 0.76s (± 0.76%) +0.01s (+ 0.66%) 0.75s 0.78s
Check Time 5.11s (± 1.63%) 5.12s (± 1.48%) +0.01s (+ 0.16%) 4.93s 5.23s
Emit Time 3.20s (± 2.96%) 3.20s (± 2.74%) +0.00s (+ 0.06%) 3.10s 3.44s
Total Time 10.33s (± 0.32%) 10.34s (± 0.32%) +0.01s (+ 0.08%) 10.26s 10.41s
material-ui - node (v8.9.0, x64)
Memory used 452,931k (± 0.01%) 452,625k (± 0.01%) -306k (- 0.07%) 452,511k 452,746k
Parse Time 2.13s (± 0.55%) 2.12s (± 0.37%) -0.01s (- 0.28%) 2.10s 2.13s
Bind Time 0.82s (± 0.49%) 0.82s (± 0.68%) +0.00s (+ 0.12%) 0.81s 0.83s
Check Time 16.81s (± 0.80%) 16.89s (± 0.57%) +0.08s (+ 0.49%) 16.69s 17.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.75s (± 0.72%) 19.83s (± 0.48%) +0.08s (+ 0.39%) 19.62s 20.10s
Angular - node (v8.9.0, x86)
Memory used 186,176k (± 0.03%) 185,996k (± 0.03%) -180k (- 0.10%) 185,861k 186,147k
Parse Time 2.06s (± 0.31%) 2.06s (± 0.78%) +0.00s (+ 0.15%) 2.03s 2.11s
Bind Time 1.09s (± 0.53%) 1.09s (± 0.98%) -0.00s (- 0.37%) 1.07s 1.12s
Check Time 5.06s (± 0.76%) 5.10s (± 0.58%) +0.04s (+ 0.75%) 5.03s 5.15s
Emit Time 6.11s (± 0.95%) 6.17s (± 0.99%) +0.06s (+ 0.97%) 6.04s 6.36s
Total Time 14.32s (± 0.48%) 14.41s (± 0.44%) +0.09s (+ 0.66%) 14.25s 14.57s
Monaco - node (v8.9.0, x86)
Memory used 185,736k (± 0.02%) 185,751k (± 0.02%) +16k (+ 0.01%) 185,658k 185,858k
Parse Time 1.60s (± 0.66%) 1.60s (± 1.02%) -0.01s (- 0.37%) 1.57s 1.65s
Bind Time 0.78s (± 0.75%) 0.78s (± 0.71%) +0.00s (+ 0.13%) 0.77s 0.79s
Check Time 5.48s (± 0.40%) 5.52s (± 0.61%) +0.04s (+ 0.64%) 5.43s 5.59s
Emit Time 2.88s (± 1.27%) 2.88s (± 0.92%) +0.00s (+ 0.10%) 2.83s 2.94s
Total Time 10.74s (± 0.48%) 10.78s (± 0.45%) +0.03s (+ 0.32%) 10.66s 10.88s
TFS - node (v8.9.0, x86)
Memory used 167,367k (± 0.02%) 167,368k (± 0.02%) +2k (+ 0.00%) 167,298k 167,440k
Parse Time 1.30s (± 0.53%) 1.29s (± 0.68%) -0.00s (- 0.15%) 1.28s 1.32s
Bind Time 0.73s (± 1.59%) 0.72s (± 0.77%) -0.00s (- 0.69%) 0.71s 0.73s
Check Time 4.72s (± 0.58%) 4.70s (± 0.32%) -0.02s (- 0.40%) 4.67s 4.75s
Emit Time 3.00s (± 0.80%) 3.01s (± 1.94%) +0.01s (+ 0.27%) 2.92s 3.23s
Total Time 9.75s (± 0.42%) 9.73s (± 0.69%) -0.02s (- 0.22%) 9.64s 9.98s
material-ui - node (v8.9.0, x86)
Memory used 256,618k (± 0.02%) 256,494k (± 0.02%) -124k (- 0.05%) 256,421k 256,609k
Parse Time 2.19s (± 0.57%) 2.19s (± 0.55%) 0.00s ( 0.00%) 2.17s 2.21s
Bind Time 0.69s (± 0.89%) 0.70s (± 1.14%) +0.01s (+ 1.59%) 0.68s 0.72s
Check Time 15.48s (± 0.51%) 15.56s (± 0.82%) +0.08s (+ 0.49%) 15.26s 15.81s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.36s (± 0.43%) 18.45s (± 0.68%) +0.09s (+ 0.48%) 18.16s 18.73s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 38792 10
Baseline master 10

@DanielRosenwasser DanielRosenwasser force-pushed the reportBaseAgainstBooleans branch from 21d3565 to cb8403b Compare May 28, 2020 19:35
@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 28, 2020

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at cb8403b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..38792

Metric master 38792 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 328,295k (± 0.02%) 327,868k (± 0.02%) -428k (- 0.13%) 327,723k 328,006k
Parse Time 1.65s (± 0.55%) 1.65s (± 0.61%) -0.01s (- 0.36%) 1.63s 1.68s
Bind Time 0.91s (± 0.95%) 0.90s (± 0.72%) -0.01s (- 0.66%) 0.89s 0.92s
Check Time 4.83s (± 0.48%) 4.84s (± 0.51%) +0.01s (+ 0.19%) 4.80s 4.90s
Emit Time 5.45s (± 1.00%) 5.42s (± 0.87%) -0.03s (- 0.57%) 5.35s 5.54s
Total Time 12.84s (± 0.54%) 12.81s (± 0.48%) -0.03s (- 0.26%) 12.71s 13.00s
Monaco - node (v10.16.3, x64)
Memory used 327,322k (± 0.02%) 327,372k (± 0.02%) +49k (+ 0.02%) 327,252k 327,491k
Parse Time 1.28s (± 0.45%) 1.28s (± 0.51%) -0.00s (- 0.16%) 1.27s 1.30s
Bind Time 0.79s (± 0.43%) 0.79s (± 0.43%) -0.01s (- 0.76%) 0.78s 0.79s
Check Time 4.89s (± 0.45%) 4.87s (± 0.58%) -0.03s (- 0.53%) 4.81s 4.95s
Emit Time 2.97s (± 0.62%) 2.95s (± 0.87%) -0.02s (- 0.74%) 2.89s 3.00s
Total Time 9.93s (± 0.33%) 9.88s (± 0.47%) -0.05s (- 0.54%) 9.78s 9.99s
TFS - node (v10.16.3, x64)
Memory used 292,416k (± 0.01%) 292,433k (± 0.02%) +16k (+ 0.01%) 292,221k 292,545k
Parse Time 0.97s (± 0.75%) 0.96s (± 0.49%) -0.01s (- 0.93%) 0.95s 0.97s
Bind Time 0.76s (± 0.77%) 0.76s (± 0.88%) 0.00s ( 0.00%) 0.74s 0.77s
Check Time 4.38s (± 0.28%) 4.37s (± 0.59%) -0.00s (- 0.02%) 4.32s 4.43s
Emit Time 3.08s (± 0.88%) 3.11s (± 0.66%) +0.03s (+ 0.97%) 3.06s 3.16s
Total Time 9.18s (± 0.32%) 9.20s (± 0.35%) +0.02s (+ 0.21%) 9.13s 9.28s
material-ui - node (v10.16.3, x64)
Memory used 449,955k (± 0.01%) 449,713k (± 0.01%) -242k (- 0.05%) 449,640k 449,819k
Parse Time 1.79s (± 0.39%) 1.78s (± 0.56%) -0.01s (- 0.28%) 1.76s 1.81s
Bind Time 0.70s (± 0.83%) 0.70s (± 0.43%) -0.01s (- 0.71%) 0.69s 0.70s
Check Time 12.91s (± 0.74%) 12.87s (± 0.74%) -0.04s (- 0.33%) 12.71s 13.12s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.40s (± 0.65%) 15.35s (± 0.62%) -0.05s (- 0.34%) 15.19s 15.61s
Angular - node (v12.1.0, x64)
Memory used 303,785k (± 0.02%) 303,486k (± 0.02%) -299k (- 0.10%) 303,301k 303,597k
Parse Time 1.60s (± 0.39%) 1.59s (± 0.57%) -0.01s (- 0.75%) 1.57s 1.61s
Bind Time 0.89s (± 0.77%) 0.88s (± 0.85%) -0.00s (- 0.23%) 0.87s 0.90s
Check Time 4.75s (± 0.55%) 4.74s (± 0.49%) -0.01s (- 0.29%) 4.69s 4.81s
Emit Time 5.57s (± 0.42%) 5.56s (± 1.05%) -0.00s (- 0.02%) 5.46s 5.74s
Total Time 12.80s (± 0.37%) 12.78s (± 0.61%) -0.03s (- 0.21%) 12.67s 12.97s
Monaco - node (v12.1.0, x64)
Memory used 307,258k (± 0.02%) 307,266k (± 0.02%) +7k (+ 0.00%) 307,131k 307,467k
Parse Time 1.23s (± 0.50%) 1.23s (± 0.82%) -0.01s (- 0.49%) 1.21s 1.25s
Bind Time 0.76s (± 1.02%) 0.76s (± 0.79%) -0.00s (- 0.66%) 0.75s 0.77s
Check Time 4.68s (± 0.50%) 4.69s (± 0.67%) +0.01s (+ 0.28%) 4.62s 4.76s
Emit Time 3.01s (± 0.82%) 3.00s (± 1.00%) -0.01s (- 0.27%) 2.95s 3.08s
Total Time 9.68s (± 0.52%) 9.68s (± 0.44%) -0.00s (- 0.03%) 9.56s 9.76s
TFS - node (v12.1.0, x64)
Memory used 274,699k (± 0.02%) 274,689k (± 0.02%) -10k (- 0.00%) 274,557k 274,829k
Parse Time 0.94s (± 0.99%) 0.93s (± 0.81%) -0.00s (- 0.32%) 0.91s 0.94s
Bind Time 0.73s (± 0.89%) 0.74s (± 1.29%) +0.01s (+ 1.10%) 0.72s 0.76s
Check Time 4.32s (± 0.46%) 4.32s (± 0.28%) +0.00s (+ 0.07%) 4.29s 4.35s
Emit Time 3.13s (± 0.95%) 3.11s (± 0.47%) -0.02s (- 0.61%) 3.07s 3.14s
Total Time 9.11s (± 0.53%) 9.10s (± 0.28%) -0.01s (- 0.08%) 9.03s 9.14s
material-ui - node (v12.1.0, x64)
Memory used 427,390k (± 0.02%) 426,879k (± 0.06%) -512k (- 0.12%) 426,127k 427,150k
Parse Time 1.77s (± 0.58%) 1.76s (± 0.39%) -0.01s (- 0.85%) 1.74s 1.77s
Bind Time 0.65s (± 1.65%) 0.65s (± 1.15%) -0.00s (- 0.61%) 0.63s 0.66s
Check Time 11.55s (± 0.84%) 11.55s (± 0.97%) -0.00s (- 0.02%) 11.34s 11.81s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.97s (± 0.73%) 13.95s (± 0.79%) -0.02s (- 0.17%) 13.75s 14.19s
Angular - node (v8.9.0, x64)
Memory used 323,083k (± 0.02%) 322,751k (± 0.02%) -332k (- 0.10%) 322,628k 322,910k
Parse Time 2.13s (± 0.45%) 2.12s (± 0.42%) -0.01s (- 0.28%) 2.10s 2.14s
Bind Time 0.94s (± 0.87%) 0.94s (± 0.93%) +0.00s (+ 0.32%) 0.93s 0.96s
Check Time 5.47s (± 1.38%) 5.50s (± 1.48%) +0.03s (+ 0.55%) 5.27s 5.61s
Emit Time 6.40s (± 1.61%) 6.41s (± 1.57%) +0.01s (+ 0.17%) 6.23s 6.69s
Total Time 14.93s (± 0.46%) 14.97s (± 0.49%) +0.04s (+ 0.26%) 14.79s 15.12s
Monaco - node (v8.9.0, x64)
Memory used 325,948k (± 0.02%) 326,002k (± 0.02%) +55k (+ 0.02%) 325,893k 326,113k
Parse Time 1.56s (± 0.38%) 1.55s (± 0.44%) -0.00s (- 0.13%) 1.54s 1.57s
Bind Time 0.92s (± 1.61%) 0.91s (± 0.74%) -0.02s (- 1.73%) 0.90s 0.92s
Check Time 5.50s (± 0.60%) 5.45s (± 0.55%) -0.05s (- 0.89%) 5.40s 5.54s
Emit Time 3.49s (± 0.77%) 3.49s (± 0.65%) +0.00s (+ 0.06%) 3.44s 3.53s
Total Time 11.47s (± 0.41%) 11.40s (± 0.47%) -0.07s (- 0.61%) 11.33s 11.55s
TFS - node (v8.9.0, x64)
Memory used 292,067k (± 0.02%) 292,014k (± 0.02%) -54k (- 0.02%) 291,919k 292,164k
Parse Time 1.26s (± 0.44%) 1.26s (± 0.58%) 0.00s ( 0.00%) 1.25s 1.28s
Bind Time 0.76s (± 0.62%) 0.76s (± 0.76%) 0.00s ( 0.00%) 0.74s 0.77s
Check Time 5.08s (± 1.73%) 5.09s (± 1.73%) +0.00s (+ 0.06%) 4.89s 5.22s
Emit Time 3.23s (± 2.59%) 3.20s (± 2.99%) -0.03s (- 1.02%) 3.05s 3.40s
Total Time 10.34s (± 0.41%) 10.31s (± 0.39%) -0.03s (- 0.30%) 10.22s 10.42s
material-ui - node (v8.9.0, x64)
Memory used 452,925k (± 0.01%) 452,694k (± 0.01%) -231k (- 0.05%) 452,539k 452,809k
Parse Time 2.13s (± 0.47%) 2.12s (± 0.61%) -0.02s (- 0.80%) 2.08s 2.14s
Bind Time 0.83s (± 0.88%) 0.82s (± 0.92%) -0.00s (- 0.48%) 0.81s 0.85s
Check Time 16.92s (± 0.77%) 16.76s (± 0.72%) -0.16s (- 0.95%) 16.56s 17.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.88s (± 0.67%) 19.70s (± 0.66%) -0.18s (- 0.90%) 19.50s 20.11s
Angular - node (v8.9.0, x86)
Memory used 186,212k (± 0.02%) 186,008k (± 0.04%) -204k (- 0.11%) 185,754k 186,132k
Parse Time 2.08s (± 0.50%) 2.07s (± 0.77%) -0.01s (- 0.67%) 2.04s 2.10s
Bind Time 1.10s (± 0.68%) 1.09s (± 1.37%) -0.01s (- 0.91%) 1.07s 1.14s
Check Time 5.07s (± 0.72%) 5.08s (± 0.36%) +0.01s (+ 0.14%) 5.04s 5.11s
Emit Time 6.10s (± 1.51%) 6.08s (± 1.18%) -0.02s (- 0.39%) 5.88s 6.21s
Total Time 14.35s (± 0.82%) 14.31s (± 0.50%) -0.04s (- 0.28%) 14.14s 14.43s
Monaco - node (v8.9.0, x86)
Memory used 185,744k (± 0.02%) 185,739k (± 0.01%) -5k (- 0.00%) 185,678k 185,785k
Parse Time 1.60s (± 0.80%) 1.60s (± 0.62%) +0.00s (+ 0.19%) 1.59s 1.63s
Bind Time 0.77s (± 0.62%) 0.77s (± 0.72%) -0.00s (- 0.13%) 0.76s 0.79s
Check Time 5.50s (± 0.52%) 5.50s (± 0.77%) +0.00s (+ 0.04%) 5.43s 5.60s
Emit Time 2.88s (± 1.11%) 2.88s (± 0.71%) +0.00s (+ 0.03%) 2.84s 2.94s
Total Time 10.75s (± 0.46%) 10.75s (± 0.53%) +0.00s (+ 0.02%) 10.63s 10.87s
TFS - node (v8.9.0, x86)
Memory used 167,356k (± 0.03%) 167,336k (± 0.03%) -20k (- 0.01%) 167,274k 167,495k
Parse Time 1.30s (± 0.62%) 1.30s (± 0.58%) -0.00s (- 0.08%) 1.28s 1.31s
Bind Time 0.72s (± 0.65%) 0.72s (± 0.62%) +0.00s (+ 0.28%) 0.71s 0.73s
Check Time 4.72s (± 0.43%) 4.70s (± 0.75%) -0.02s (- 0.47%) 4.62s 4.77s
Emit Time 3.04s (± 2.87%) 2.99s (± 1.10%) -0.05s (- 1.58%) 2.90s 3.08s
Total Time 9.78s (± 0.85%) 9.71s (± 0.60%) -0.07s (- 0.74%) 9.59s 9.81s
material-ui - node (v8.9.0, x86)
Memory used 256,647k (± 0.01%) 256,489k (± 0.01%) -158k (- 0.06%) 256,405k 256,557k
Parse Time 2.20s (± 0.78%) 2.19s (± 0.80%) -0.01s (- 0.50%) 2.15s 2.23s
Bind Time 0.70s (± 0.93%) 0.69s (± 1.52%) -0.00s (- 0.72%) 0.68s 0.72s
Check Time 15.59s (± 0.71%) 15.59s (± 0.92%) -0.01s (- 0.06%) 15.34s 15.85s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.49s (± 0.62%) 18.46s (± 0.84%) -0.03s (- 0.16%) 18.22s 18.73s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 38792 10
Baseline master 10

@DanielRosenwasser
Copy link
Member Author

@sheetalkamat @RyanCavanaugh I just added an assert - do you think it's appropriate? I'd hate to bring down a compilation because an assertion was wrong. I wish there was a place to log "uh oh"s in the experience that were non-fatal.

@DanielRosenwasser DanielRosenwasser force-pushed the reportBaseAgainstBooleans branch from cb8403b to 40c3ffe Compare June 30, 2020 08:36
@DanielRosenwasser DanielRosenwasser merged commit a812a74 into master Jun 30, 2020
@DanielRosenwasser DanielRosenwasser deleted the reportBaseAgainstBooleans branch June 30, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants