-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report base primitive sources against boolean targets #38792
Conversation
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 51d0ec1. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - master..38792
System
Hosts
Scenarios
|
21d3565
to
cb8403b
Compare
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at cb8403b. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - master..38792
System
Hosts
Scenarios
|
@sheetalkamat @RyanCavanaugh I just added an assert - do you think it's appropriate? I'd hate to bring down a compilation because an assertion was wrong. I wish there was a place to log "uh oh"s in the experience that were non-fatal. |
cb8403b
to
40c3ffe
Compare
Expands @JoshuaKGoldberg's #38049 to special-case the bare
boolean
type.