Fix fileExists check for a watch program #37260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Your change certainly looks correct and, as far as I can tell, the test was expecting that file to exist so the baseline updates are probably correct as well. If there turns out to be some subtle reason this is not correct, the code definitely needs clarification.
sheetalkamat
reviewed
Mar 6, 2020
tests/baselines/reference/tscWatch/programUpdates/deleted-files-affect-project-structure-2.js
Show resolved
Hide resolved
sheetalkamat
approved these changes
Mar 6, 2020
sheetalkamat
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this when investigating repeated program recalculation when invoking
ts.Watch.getProgram()even when no changes have been made. It seems like the current behavior doesn't actually match the comment (or even seem correct at all, regardless of the comment). That being said, I'm not sure the baseline changes are correct.