Skip to content

Fix type definition of CustomEvent constructor #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

takeohman
Copy link

@msftclas
Copy link

Hi @takeohman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Feb 12, 2015

thanks for the PR. As i mentioned in #1837 this file is auto generated from the IE definition files. this makes it easy for us to get an almost accurate DOM definitions without having to update them manually. We plan on updating how the dom typings are generated but for now, we can not make hand edits to this file. If you can log a separate issue, i can get it fixed in our script and update the file.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 12, 2015

Can you file an issue to track the change

@takeohman
Copy link
Author

mhegazy,

Thank you for your comment.
I made a new issue #2029 regarding this PR.
I hope what I did is OK.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants