37405 Advanced Paste: Image To Text doesn't work with English (Canada) #37806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryolithic
force-pushed
the
37405-advanced-paste-image-to-text-doesn
branch
from
d6d9e0b to
76617a9
Compare
GetOCRLanguage may fail based on language tag not matching (en-CA does not match en-GB or en-US), however user profile language may be valid.
cryolithic
force-pushed
the
37405-advanced-paste-image-to-text-doesn
branch
from
76617a9 to
c2dfa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix advanced paste failing to create ocrEngine on some English language tags. (en-CA, others)
PR Checklist
Detailed Description of the Pull Request / Additional comments
When attempting to use AdvancedPaste Image to Text, and error was shown with stack trace in logs.
Method GetOCRLanguage compared the current language tag (en-CA) to OcrEngine.AvailableRecognizerLanguages. The returned list on my PC was en-GB, en-US. Both of these should work for OCR against en-CA.
Added check if GetOCRLanguage returned null, call TryCreateFromUserProfileLanguages. In my cases, this succeeds, however I do not know what that behaviour may lead to in other language combinations.
Validation Steps Performed
Built installer
Installed in a fresh vm with language set to en-CA
Attempted Image to Text
OCR was successful