Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerAccent] Cancel previous ShowToolbar task if a new one is triggered #37757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mantaionut
Copy link
Contributor

@mantaionut mantaionut commented Mar 5, 2025

Summary of the Pull Request

Now cancel the task of ShowToolbar if another is started,

PR Checklist

Detailed Description of the Pull Request / Additional comments

ShowToolbar would start a task with the delay of the normal input delay, this is an issue since if you release the activation key and then press it again a new task would be created, then the previous task could end and show the toolbar. This creates scenarios where showing of the toolbar is not always at the same time.

Validation Steps Performed

Tested by using 300ms delay.
Tested by using 5000ms delay. Hold the spacebar for 3 seconds release and then hold it again for 5 seconds. Previously the taskbar would be triggered at the second hold after holding it for 2 seconds, Now it is shown after holding it for 5 seconds.

@mantaionut mantaionut changed the title Cancel previous ShowToolbar task if a new one is triggered [PowerAccent] Cancel previous ShowToolbar task if a new one is triggered Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant