Beta 0.5 Progress #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slvnperron
commented
Jan 5, 2015
slvnperron
commented
- Using the builtin Lambda RequestID instead of generating our own
- Renamed sqsHelper to SQSHelper for consistency
- Implemented uploading modules with dependencies
| var configsAsStr = JSON.stringify(configs), | ||
| identifier = [MODULE_HASH_PREFIX, modulePath, handlerName, deps, configsAsStr].join('_'); | ||
|
|
||
| return md5(identifier); // TODO : add config in hash? |
|
Great job man ! |
| exports.create = function (func, config) { | ||
| return _lambdaHelper.getCloudedFunction(func, config); | ||
| exports.create = function () { | ||
| if(typeof(arguments[0]) === 'function') { |
There was a problem hiding this comment.
what if my function uses deps ?
There was a problem hiding this comment.
it can't use deps if the function is inlined atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.