Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Reduce excessive recentering #75

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Fix: Reduce excessive recentering #75

merged 5 commits into from
Aug 3, 2023

Conversation

cizl
Copy link
Contributor

@cizl cizl commented Aug 3, 2023

No description provided.

@cizl cizl changed the title New/fix recenter Fix: Reduce excessive recentering Aug 3, 2023
tonilastre
tonilastre approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@tonilastre tonilastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like you have the same changes again (partially). Have you pulled new/simulator-fixes before.
I am talking about zoomIn and zoomOut functions.

@cizl
Copy link
Contributor Author

cizl commented Aug 3, 2023

I feel like you have the same changes again (partially). Have you pulled new/simulator-fixes before. I am talking about zoomIn and zoomOut functions.

I noticed. I just wanted to push it to GH to better see changes, that's why i put it in the draft. But something here is out of whack. Yesterday I had issues with github not picking up changes that I pushed.

@cizl cizl changed the base branch from new/simulator-fixes to main August 3, 2023 09:43
@cizl cizl changed the base branch from main to new/simulator-fixes August 3, 2023 09:43
@cizl cizl marked this pull request as ready for review August 3, 2023 10:46
@cizl cizl self-assigned this Aug 3, 2023
@cizl cizl added the bug Something isn't working label Aug 3, 2023
@cizl
Copy link
Contributor Author

cizl commented Aug 3, 2023

@tonilastre I have no idea what's going on with GH.

on new/simulator-fixes, there is only the following commit:

  • New: Add zoom and recenter functions (faa9eed)

But in the already closed PR it looks like 2 commits should have been merged:

  • New: Add zoom and recenter functions (faa9eed)
  • Fix: reuse this.render (54d87c6)

And now, this PR tries to add everything??

@tonilastre
Copy link
Contributor

Yep, that is strange, but I see it good now on the UI.

Btw even the hash of the commit is different. But that might be due to the Squash + Merge.

Btw this is approved, all good here.

@cizl cizl merged commit e6e0a0d into new/simulator-fixes Aug 3, 2023
@cizl cizl deleted the new/fix-recenter branch August 3, 2023 12:11
AlexIchenskiy added a commit that referenced this pull request Mar 27, 2024
@tonilastre @cizl @AlexIchenskiy
New: Add new simulator (#56) (#57)
2530739 
* New: Add new simulator (#56)

* New: Add simulator scenarios for manual testing
* New: Refactor simulator (WIP)
* New: Add progress overlay, Update descriptions
* Fix: Introduce new simulator event, Fix main-thread behavior
* Fix: Rearrange class methods based on visibility
* Fix: Improve naming
* Chore(release): 0.2.0
* Fix: Tweak simulator, adjust API slightly
* Fix: Temporarily patch some physics behavior
* Fix: Adjust re-heating parameters
* Fix: tweak physics behavior -> immediately stop sim when disabling
* Chore: Remove the beta from release branches

---------

Co-authored-by: dlozic <[email protected]>

* New: Add zoom and recenter functions (#74)

* New: Add zoom and recenter functions

* Fix: Reduce excessive recentering (#75)

* Fix: Remove excessive recenterings
* Fix: Remove unused code

* Fix: New simulator (#92)

* Chore: Refactor naming

* New: Add new events

* Chore: Refactor code styling

* Docs: Remove unused flags

* Chore: Remove unused simulation functions

* Chore: Refactor view render function calls

* Chore: Add missing tests

* New: Add removal functions (#96)

* New: Add removal functions

* Fix: Add missing callback data

* Chore: Refactor remove return values

* Chore: Refactor remove function type usage

* Fix: Default settings for node placement (#98)

* New: Add properties setters and getters (#93)

* New: Add node properties setters

* New: Add edge properties setters

* New: Add properties getters

* New: Add patch for nodes and edges

* Fix: Make getters return copies

* Fix: Edge factory listeners copying

* Fix: Jest outdated tests

* Fix: Github actions node version

* Chore: Refactor observer interface

* Chore: Refactor node/edge constructor settings

* Chore: Refactor node/edge function grouping

* Chore: Refactor node/edge function grouping

* Fix: Listeners behaviour

* Chore: Refactor property copying

* Chore: Refactor subject implementation

* Fix: Set position behaviour on node drag

* Chore: Upgrade node version

* Chore: Refactor function type check

* Fix: Remove listener behaviour

* Chore: Refactor util naming

* Chore: Remove unused type assertion

* Chore: Refactor position setter options

* Chore: Refactor property patch function

* Fix: Set map node position behaviour

* Chore: Refactor simulator data patching

* Chore: Change observers to callbacks

* New: Add state setters with options (#95)

* New: Add state setters with options

* Chore: Remove leftover comments

* Chore: Refactor state setter logic

* Chore: Refactor state types

* Fix: Rename merged function usage

* Fix: Merged variable naming

* Chore: Fix tests

---------

Co-authored-by: dlozic <[email protected]>
Co-authored-by: Oleksandr Ichenskyi <[email protected]>
Co-authored-by: AlexIchenskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonilastre tonilastre tonilastre approved these changes

Assignees

@cizl cizl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cizl @tonilastre