fix(constructor): prevent null values from blowing up - #321

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The release notes tracked in this document are also made available on the [releases page](https://github.com/medialize/URI.js/releases)
 
+### master
+
+* prevent `new URI(null)` from blowing up - [PR #321](https://github.com/medialize/URI.js/issues/321)
+
 ### 1.18.4 (December 4th 2016) ###
 
 * fixing [`URI.withinString()`](http://medialize.github.io/URI.js/docs.html#static-withinString) to capture balanced parentheses - [Issue #247](https://github.com/medialize/URI.js/issues/247)

src/URI.js

@@ -61,6 +61,12 @@
       }
     }
 
+    if (url === null) {
+      if (_urlSupplied) {
+        throw new TypeError('null is not a valid argument for URI');
+      }
+    }
+
     this.href(url);
 
     // resolve to base according to http://dvcs.w3.org/hg/url/raw-file/tip/Overview.html#constructor

test/test.js

@@ -19,6 +19,11 @@
       URI(undefined);
     }, TypeError, 'Failing undefined input');
   });
+  test('URI(null)', function() {
+    raises(function() {
+      URI(null);
+    }, TypeError, 'Failing undefined input');
+  });
   test('new URI(string)', function() {
     var u = new URI('http://example.org/');
     ok(u instanceof URI, 'instanceof URI');