Fix issue 28997: better example of passive listeners #29083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbamberg
requested review from
sideshowbarker
and removed request for
a team
|
Preview URLs |
|
But I suppose we should also fix #24181 here, while we are at it. |
wbamberg
changed the title
sideshowbarker
approved these changes
Sep 14, 2023
|
Wow! This is so well written, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28997.
This is a much more extensive than I intended fix for #28997.
The main point of #28997 was that
scrollis an inappropriate event to choose, because it's not cancellable (as the page itself already says). But also, the example showed a lot of feature-detection stuff, which I don't think is very relevant any more, and didn't show anything about the actual effect of the option.So I have:
passiveon awheeleventAll that is in commit 9b37e12.
Then I realized that this page contains two H2 sections, "Usage notes" and "Other notes", which seemed ridiculous, so I merged them in commit d2e114b. So that commit is really just moving stuff around.