Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot: zephyr: add ram_load overlays for nrf52840dk and mimxrt1050_evk boards #2196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieldegrasse
Copy link
Contributor

Add ram load overlays for nrf52840dk and mimxrt1050_evk boards. These ram load overlays are moved from the Zephyr in tree smp_svr sample, to enable ram load support for multiple platforms.

Comment on lines 2 to 4
sram@2003FC00 {
compatible = "zephyr,memory-region", "mmio-sram";
reg = <0x2003FC00 DT_SIZE_K(1)>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sram@2003FC00 {
compatible = "zephyr,memory-region", "mmio-sram";
reg = <0x2003FC00 DT_SIZE_K(1)>;
sram@2003FF00 {
compatible = "zephyr,memory-region", "mmio-sram";
reg = <0x2003FF00 0x100>;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieldegrasse Can you respond or make changes, so that we can go through with this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, should be fixed now

@danieldegrasse danieldegrasse force-pushed the feature/ramload-overlays branch from c195d33 to 95b4aea Compare February 4, 2025 18:16
… boards

Add ram load overlays for nrf52840dk and mimxrt1050_evk boards. These
ram load overlays are moved from the Zephyr in tree smp_svr sample, to
enable ram load support for multiple platforms.

Signed-off-by: Daniel DeGrasse <[email protected]>
@danieldegrasse danieldegrasse force-pushed the feature/ramload-overlays branch from 95b4aea to 93398ca Compare February 4, 2025 18:19
@danieldegrasse
Copy link
Contributor Author

Is the CI failure here expected, because a new revision of Zephyr would be needed to make this overlay work correctly?

@nordicjm
Copy link
Collaborator

nordicjm commented Feb 6, 2025

Is the CI failure here expected, because a new revision of Zephyr would be needed to make this overlay work correctly?

Yes failure here is fine since it's trying to build zephyr's main smp_svr which fails without changes in your PR

@danieldegrasse
Copy link
Contributor Author

@nordicjm what is needed to move this PR forwards? I'm not sure what makes the most sense to sequence this PR since it requires changes on the Zephyr side

@nordicjm
Copy link
Collaborator

nordicjm commented Mar 3, 2025

@nordicjm what is needed to move this PR forwards? I'm not sure what makes the most sense to sequence this PR since it requires changes on the Zephyr side

@de-nordic please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants