Support middle-click on history items #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic support for middle-clicking on links in the history panel.
If the user has the setting "Mouse > Bookmarks actions > Middle-click on the bookmark" set to "open in new tab", so that middle-clicking a bookmark opens it in a new tab without navigating away from the bookmarks panel or resetting the search input, then middle-click will behave the same way in the bookmarks panel.
As referenced:
...middle-clicking these items currently does nothing.
Ideally the extension would support a range of mouse settings for the history panel, as it does for the bookmarks panel. I've not implemented that here though. Seems to me that a user would rarely want the on-click behavior of history items to be different to that of bookmarks, so the approach here is just to pull from the bookmarks' settings.