Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "hide group tabs" #872

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Create a "hide group tabs" #872

merged 1 commit into from
Nov 30, 2022

Conversation

sarchar
Copy link
Contributor

@sarchar sarchar commented Nov 30, 2022

The hide groups option will hide group tabs when the group is folded and not selected.

Useful for windows that have a lot of tab groups, as the tab group pages tend to clutter the the tabs bar.

The hide groups option will hide group tabs when the group is folded and not selected.

Useful for windows that have a lot of tab groups, as the tab group pages tend to clutter the the tabs bar.
@sarchar
Copy link
Contributor Author

sarchar commented Nov 30, 2022

Hey everyone,

I have a LOT of tab groups, and thus a lot of tab group pages. I have found that it's nearly impossible to navigate using the top tabs bar of the browser window when it's 90% tab group pages.

I believe this new feature will be quite useful to others but my implementation is probably incomplete. There may be many, many edge cases that don't properly hide the group tabs. Please let me know and I will try to cover those as they're discovered.

Also, since I'm not familiar at all with the code base, I'm sure I missed out on making use of the proper API to do things. In particular, I think tab.vue could be improved by using a deselect tab event/callback but I'm unaware of any that exist already.

Cheers,
Sarchar

@sarchar
Copy link
Contributor Author

sarchar commented Nov 30, 2022

To demonstrate the difference, here is before:

image

And after with tabs collapsed:

image

@mbnuqw
Copy link
Owner

mbnuqw commented Nov 30, 2022

Thank you, this PR has a few issues, but it's a good start, I'll merge it and complete the implementation.

This feature was requested in #831 (just a mention)

@mbnuqw mbnuqw merged commit be221a4 into mbnuqw:v5 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants