Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Open new tab in container if required #322

Closed
wants to merge 1 commit into from

Conversation

ozars
Copy link

@ozars ozars commented Nov 10, 2020

New tabs are opened in the panel's container if they're configured to do so.

Fixes #305.
Fixes #316.

Thanks for this great addon.

@ozars
Copy link
Author

ozars commented Nov 10, 2020

This will override containers of tabs opened from another pages even if the container of the parent tab isn't same as with the one set for the panel if "Open new tab in container" setting is enabled. I guess this behavior can be modified to respect parent's container if this is more convenient.

@ozars
Copy link
Author

ozars commented Nov 10, 2020

Uh-oh never mind. This looked like it worked, but it just shows as if it works in the GUI while not really setting tab's container properly. I figured after trying a container with SOCKS proxy and realized it doesn't actually update underlying container.

Not sure if this can be done without tabs.update() providing a property to update cookieStoreId for existing tabs or by reopening tab with correct cookieStoreId which is quite ugly. So, closing this PR.

@ozars ozars closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Ctrl + T" don't respect the automatic container affectation New tab in panel don't open in container
1 participant