Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search: minimum search query length in CJK should be 1. #1985

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

llc0930
Copy link
Contributor

@llc0930 llc0930 commented Jan 26, 2025

In short, the minimum search query length required for our writing system is 1.

The reason why CJK Unified Ideographs Extension B-I are not included is because those characters are too rare... I think they can pretty much only be entered using code points directly... and therefore it is unlikely to be used for naming and searching titles.

Let's look at a simple example in Traditional Chinese:
Monday = 週一 = 星期一
Tuesday = 週二 = 星期二
Wednesday = 週三 = 星期三
Thursday = 週四 = 星期四
Friday = 週五 = 星期五
Saturday = 週六 = 星期六
Sunday = 週日 = 星期日 = 星期天
When we want to search for each day of the week, one of the situations we might want to search by just "週".

When the query string length is 1, check whether it is a CJK character.
@mbnuqw
Copy link
Owner

mbnuqw commented Jan 27, 2025

Thanks

@mbnuqw mbnuqw merged commit 7cbc197 into mbnuqw:v5 Jan 27, 2025
@llc0930 llc0930 deleted the search_query_len branch January 27, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants