Don't count double-clicking the title editor as double-clicking the tab #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, if a tab action is set to run when double-clicking on a tab, and you double-click the text while editing a tab's title, don't run the tab action.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if a tab action is set to run when double-clicking on a tab, and you double-click the text while editing a tab's title, don't run the tab action.
I noticed this because I have double-click set to edit title, and tried to double-click while editing to select a word, however this is what happens:
Screen.Recording.2023-12-08.at.14.29.37.mov
It re-runs the action, resetting the title value and the selection. Note that this change only affects double-clicks inside the text input field, because if you click a different part of the tab, the first click will blur the input.