Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing last tab of current panel goes to wrong tab #851

Open
msmol opened this issue Nov 16, 2022 · 6 comments
Open

Closing last tab of current panel goes to wrong tab #851

msmol opened this issue Nov 16, 2022 · 6 comments
Labels
reproduced: yes type: bug

Comments

@msmol
Copy link

msmol commented Nov 16, 2022

Steps to reproduce

  • Open Firefox in new profile
  • Install Sidebery
  • set After closing current tab activate to next tab
  • set Hide native tabs of inactive panels to on
  • close the last tab of your current panel

Expected behavior

The top tab of the current panel (or maybe second to last tab of current panel) is activated since tabs of next panel are hidden by Hide native tabs of inactive panels

Actual behavior

The first tab of the next panel is activated

Debug info

Addon data { "addonVersion": "5.0.0b29", "firefoxVersion": "106.0.5", "settings": { "nativeScrollbars": true, "nativeScrollbarsThin": true, "nativeScrollbarsLeft": false, "selWinScreenshots": false, "updateSidebarTitle": true, "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": true, "ctxMenuRenderInact": true, "ctxMenuRenderIcons": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": false, "navBarSide": "left", "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": false, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navTabsPanelMidClickAction": "none", "navBookmarksPanelMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "list", "skipEmptyPanels": false, "dndTabAct": false, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "none", "dndExpDelay": 0, "dndExpMod": "none", "dndOutside": "win", "searchBarMode": "dynamic", "warnOnMultiTabClose": "none", "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "hideInact": true, "activateAfterClosing": "next", "activateAfterClosingGlobal": true, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsUpdateMark": "all", "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "showNewTabBtns": false, "newTabBarPosition": "bottom", "tabsPanelSwitchActMove": true, "tabsUrlInTooltip": "full", "openSubPanelOnMouseHover": false, "colorizeTabs": false, "colorizeTabsSrc": "domain", "moveNewTabPin": "start", "moveNewTabParent": "none", "moveNewTabParentActPanel": false, "moveNewTab": "end", "moveNewTabActivePin": "start", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": false, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "colorizeTabsBranches": false, "colorizeTabsBranchesSrc": "url", "warnOnMultiBookmarkDelete": "collapsed", "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "loadBookmarksOnDemand": true, "pinOpenedBookmarksFolder": true, "loadHistoryOnDemand": true, "fontSize": "xxs", "animations": true, "animationSpeed": "fast", "theme": "proton", "density": "default", "colorScheme": "ff", "sidebarCSS": true, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollAction": "none", "navSwitchPanelsDelay": 128, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "scrollThroughTabsScrollArea": 0, "autoMenuMultiSel": true, "multipleMiddleClose": false, "longClickDelay": 500, "wheelThreshold": false, "wheelThresholdX": 10, "wheelThresholdY": 60, "tabDoubleClick": "none", "tabsSecondClickActPrev": true, "shiftSelAct": true, "activateOnMouseUp": true, "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabCloseMiddleClick": "close", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "newTabMiddleClickAction": "new_child", "bookmarksLeftClickAction": "open_in_act", "bookmarksLeftClickActivate": false, "bookmarksLeftClickPos": "default", "bookmarksMidClickAction": "open_in_new", "bookmarksMidClickActivate": false, "bookmarksMidClickPos": "default", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncSaveKeybindings": false }, "permissions": { "allUrls": false, "tabHide": true, "clipboardWrite": true, "webRequest": false, "webRequestBlocking": false }, "storage": { "size": "109 kb", "props": { "containers": "1.25 kb", "favDomains": "12.4 kb", "favHashes": "1.1 kb", "favicons": "76.4 kb", "groupCSS": "2 b", "panelIndex": "1 b", "prevTabsDataCache": "4.55 kb", "profileID": "14 b", "settings": "3.61 kb", "sidebar": "1.12 kb", "sidebarCSS": "60 b", "tabsDataCache": "8.05 kb", "ver": "10 b" } }, "sidebar": { "panels": { "firefox-default": { "type": 2, "id": "firefox-default", "name": "len: 4", "color": "toolbar", "iconSVG": "briefcase", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "oUe9jQE0gmHN": { "type": 2, "id": "oUe9jQE0gmHN", "name": "len: 8", "color": "toolbar", "iconSVG": "icon_man", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "p6eru0cMEUFN": { "type": 2, "id": "p6eru0cMEUFN", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_lock", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] } }, "nav": [ "firefox-default", "oUe9jQE0gmHN", "p6eru0cMEUFN", "sp-0", "settings" ] }, "containers": [ { "id": "firefox-container-1", "cookieStoreId": "firefox-container-1", "name": "8", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-2", "cookieStoreId": "firefox-container-2", "name": "4", "icon": "...", "color": "orange", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "cookieStoreId": "firefox-container-3", "name": "7", "icon": "...", "color": "green", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "cookieStoreId": "firefox-container-4", "name": "8", "icon": "...", "color": "pink", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "sidebarCSSLen": "53", "windows": [ { "state": "normal", "incognito": false, "tabsCount": 61 } ], "bookmarks": { "bookmarksCount": 37, "foldersCount": 9, "separatorsCount": 0, "maxDepth": 3 } }
Logs
@VBoudry
Copy link

VBoudry commented Dec 7, 2022

I have exactly the same problem on FF107, since a couple of weeks.
I have tried all the options in the Tabs configuration panel: whatever the option chosen (previously active, next, previous or none), closing the last tab in a panel will switch to the previously modified panel.

mbnuqw added a commit that referenced this issue Dec 14, 2022
@mbnuqw
Fixed: Wrong "Activate after closing" behavoir with non-tree structure
e3cb246 
(#851)
@VBoudry
Copy link

VBoudry commented Feb 16, 2023

Can this be soon looked at, as this makes the navigation really painful (verify and eventually move away from the last tab before closing it; switch back to the previous tab manually if you forgot to do so) ?

@mbnuqw
Copy link
Owner

mbnuqw commented Feb 18, 2023

@VBoudry, are you using the last beta version (v5) or the stable (v4)? Does the issue reproduce in clean Firefox profile with only sidebery installed? Could you also provide the addon debug info (In sidebery settings / Help section).

@Tu13es
Copy link

Tu13es commented Feb 18, 2023

I was seeing the issue in v4, and just installed the beta and it no longer reproduces. 👍

@VBoudry
Copy link

VBoudry commented Feb 21, 2023 via email

@VBoudry
Copy link

VBoudry commented Mar 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reproduced: yes type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@msmol @VBoudry @mbnuqw @Tu13es