Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] - Closing a Tab in Search Mode is not reflected #816

Closed
theurichde opened this issue Oct 25, 2022 · 1 comment
Closed

[v5] - Closing a Tab in Search Mode is not reflected #816

theurichde opened this issue Oct 25, 2022 · 1 comment

Comments

@theurichde
Copy link

theurichde commented Oct 25, 2022

First at all: Thank you for this great, awesome and enlighting plugin! 💟

Steps to reproduce

  • Open Firefox in new profile
  • Install Sidebery
  • Open a few tabs
  • Search for a tab
  • Try to close the tab in the search panel

Expected behavior

Closed tabs should be closed in the search panel / mode, too

Actual behavior

  • When one closes a tab in search mode, it is not removed from search view
  • It is closed in the normal view

Debug info

Addon data { "settings": { "nativeScrollbars": false, "nativeScrollbarsThin": true, "nativeScrollbarsLeft": false, "selWinScreenshots": true, "updateSidebarTitle": true, "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "ctxMenuRenderInact": true, "ctxMenuRenderIcons": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": false, "navBarSide": "left", "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navTabsPanelMidClickAction": "none", "navBookmarksPanelMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "dndOutside": "win", "searchBarMode": "static", "warnOnMultiTabClose": "collapsed", "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "hideInact": true, "activateAfterClosing": "prev_act", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsUpdateMark": "all", "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "showNewTabBtns": true, "newTabBarPosition": "after_tabs", "tabsPanelSwitchActMove": true, "tabsUrlInTooltip": "full", "openSubPanelOnMouseHover": false, "colorizeTabs": false, "colorizeTabsSrc": "domain", "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "moveNewTabActivePin": "start", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": true, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "folded", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": true, "discardFoldedDelay": 5, "discardFoldedDelayUnit": "min", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "colorizeTabsBranches": false, "colorizeTabsBranchesSrc": "url", "warnOnMultiBookmarkDelete": "collapsed", "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "loadBookmarksOnDemand": true, "pinOpenedBookmarksFolder": true, "loadHistoryOnDemand": true, "fontSize": "m", "animations": true, "animationSpeed": "fast", "theme": "proton", "colorScheme": "ff", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 1, "snapIntervalUnit": "day", "snapLimit": 365, "snapLimitUnit": "day", "hScrollAction": "none", "navSwitchPanelsDelay": 128, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "scrollThroughTabsScrollArea": 0, "autoMenuMultiSel": true, "multipleMiddleClose": false, "longClickDelay": 500, "wheelThreshold": false, "wheelThresholdX": 10, "wheelThresholdY": 60, "tabDoubleClick": "none", "tabsSecondClickActPrev": true, "shiftSelAct": true, "activateOnMouseUp": true, "tabLongLeftClick": "clear_cookies", "tabLongRightClick": "none", "tabCloseMiddleClick": "close", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "newTabMiddleClickAction": "new_child", "bookmarksLeftClickAction": "open_in_act", "bookmarksLeftClickActivate": false, "bookmarksLeftClickPos": "default", "bookmarksMidClickAction": "open_in_new", "bookmarksMidClickActivate": false, "bookmarksMidClickPos": "default", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncSaveKeybindings": false }, "permissions": { "allUrls": false, "tabHide": true, "clipboardWrite": false, "webRequest": false, "webRequestBlocking": false }, "storage": { "size": "2.68 mb", "props": { "containers": "1.65 kb", "favDomains": "1.61 kb", "favHashes": "254 b", "favicons": "16.1 kb", "groupCSS": "2 b", "lastSnapTime": "13 b", "panelIndex": "1 b", "prevTabsDataCache": "16.7 kb", "profileID": "14 b", "settings": "3.62 kb", "sidebar": "1.01 kb", "sidebarCSS": "2 b", "snapshots": "2.63 mb", "tabsDataCache": "16.3 kb", "ver": "10 b" } }, "sidebar": { "panels": { "bookmarks": { "type": 1, "id": "bookmarks", "name": "len: 11", "iconSVG": "icon_bookmarks", "iconIMGSrc": "", "iconIMG": "", "color": "toolbar", "lockedPanel": false, "tempMode": false, "skipOnSwitching": false, "rootId": "root________", "viewMode": "tree", "autoConvert": false }, "firefox-default": { "type": 2, "id": "firefox-default", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_tabs", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] }, "-hK7CUabn-GS": { "type": 2, "id": "-hK7CUabn-GS", "name": "len: 6", "color": "red", "iconSVG": "fence", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-container-6", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "", "bookmarksFolderId": -1, "newTabBtns": [] } }, "nav": [ "bookmarks", "firefox-default", "-hK7CUabn-GS", "add_tp", "sp-0", "settings" ] }, "containers": [ { "id": "firefox-container-6", "name": "6", "icon": "...", "color": "toolbar", "proxified": false, "proxy": { "type": "direct" }, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "", "cookieStoreId": "firefox-container-6", "colorCode": "#37adff" }, { "id": "firefox-container-1", "cookieStoreId": "firefox-container-1", "name": "8", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-2", "cookieStoreId": "firefox-container-2", "name": "6", "icon": "...", "color": "orange", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "cookieStoreId": "firefox-container-3", "name": "7", "icon": "...", "color": "green", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "cookieStoreId": "firefox-container-4", "name": "9", "icon": "...", "color": "pink", "colorCode": "#37adff", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "windows": [ { "state": "normal", "incognito": false, "tabsCount": 143 }, { "state": "normal", "incognito": true, "tabsCount": 2 }, { "state": "normal", "incognito": true, "tabsCount": 4 } ], "bookmarks": { "bookmarksCount": 26, "foldersCount": 9, "separatorsCount": 0, "maxDepth": 2 } }
Logs

Edit:

  • Running on Firefox 106.0 (64-Bit)
  • Using Sidebery 5.0.0b27
@mbnuqw
Copy link
Owner

mbnuqw commented Jan 26, 2023

Fixed in v5.0.0b30.

@mbnuqw mbnuqw closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants