Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix arm docker images #9423

Closed
wants to merge 7 commits into from
Closed

Fix arm docker images #9423

wants to merge 7 commits into from

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Feb 17, 2021

c.f. #9403

Basically building the cryptography package now requires rust to build, which fetches packages from crates.io. Fetching packages breaks when building for 32bit arch on 64bit platforms, so we create a base image that has the packages already downloaded. This allowis us to run rustc/cargo in offline mode, which doesn't break.

We don't want to do this by default however, as cryptography ships wheels for most platforms and so the extra steps are entirely unnecessary.

Does anyone know of a good way of testing this works on circle CI? I have tested locally

@erikjohnston erikjohnston force-pushed the erikj/arm_docker_cache branch from aeef3fa to 1dd584b Compare February 17, 2021 17:46
@erikjohnston
Copy link
Member Author

Note that as per https://github.com/docker/buildx#--driver-driver multi platform images can't be loaded into the local docker images, so we have to push our intermediate cargo cache images to a local repository that we spin up.

@erikjohnston
Copy link
Member Author

Also note that the last commit enables building of images for this branch and disables push to docker hub so that we can test it actually works.

@erikjohnston erikjohnston requested a review from a team February 17, 2021 17:49
@erikjohnston
Copy link
Member Author

Ugh, now the docker builds are timing out :/

@erikjohnston erikjohnston added the X-Release-Blocker Must be resolved before making a release label Feb 18, 2021
@erikjohnston erikjohnston removed the X-Release-Blocker Must be resolved before making a release label Feb 18, 2021
@clokep
Copy link
Member

clokep commented Feb 18, 2021

@erikjohnston Are we closing this then?

@clokep clokep removed the request for review from a team February 18, 2021 19:40
@erikjohnston
Copy link
Member Author

We've decided to drop support for ARMv7, so yeah

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants