This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeef3fa
to
1dd584b
Compare
Note that as per https://github.com/docker/buildx#--driver-driver multi platform images can't be loaded into the local |
Also note that the last commit enables building of images for this branch and disables push to docker hub so that we can test it actually works. |
Ugh, now the docker builds are timing out :/ |
Merged
@erikjohnston Are we closing this then? |
We've decided to drop support for ARMv7, so yeah |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #9403
Basically building the
cryptography
package now requires rust to build, which fetches packages from crates.io. Fetching packages breaks when building for 32bit arch on 64bit platforms, so we create a base image that has the packages already downloaded. This allowis us to run rustc/cargo in offline mode, which doesn't break.We don't want to do this by default however, as cryptography ships wheels for most platforms and so the extra steps are entirely unnecessary.
Does anyone know of a good way of testing this works on circle CI? I have tested locally