Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Check that an appservice protocol has at least one service providing it #10532

Merged
merged 8 commits into from
Aug 5, 2021
+125 −5
Merged

Check that an appservice protocol has at least one service providing it #10532

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cc4a3d
Check that a appservice protocol has at least one service
Half-Shot Aug 4, 2021
67527f6
Remove len
Half-Shot Aug 4, 2021
91c4d3f
Remove redundant if check
Half-Shot Aug 4, 2021
aeb8046
Lint
clokep Aug 4, 2021
d5e8636
Add tests for get_3pe_protocols
Half-Shot Aug 4, 2021
5704f62
Merge branch 'hs/only-show-protocols-if-one-service-exists' of github…
Half-Shot Aug 4, 2021
cced86e
Name function s/someFunc/get_3pe_protocol
Half-Shot Aug 4, 2021
8eb7479
Update changelog.d/10532.bugfix
Half-Shot Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update changelog.d/10532.bugfix 
Co-authored-by: Patrick Cloke <[email protected]>
@Half-Shot @clokep
Half-Shot and clokep authored Aug 5, 2021
commit 8eb7479385d37c8705cf12000a1384a7e2d76285
2 changes: 1 addition & 1 deletion changelog.d/10532.bugfix
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Only report protocols that are implemented by at least one service, as required by the spec when handling `GET /_matrix/client/r0/thirdparty/protocols`.
Fix a long-standing bug where protocols which are not implemented by any appservices were incorrectly returned via `GET /_matrix/client/r0/thirdparty/protocols`.