Use trustRoot instead of verify for request verification #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Apr 29, 2019
anoadragon453
force-pushed
the
anoa/use_trustroot
branch
from
bd22812 to
b352207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
trustRootinstead ofverifyfor specifyingCertificateOptions, asverifyhas essentially been made deprecated.This takes the same approach as the implementation in Synapse:
https://github.com/matrix-org/synapse/blob/63b75cf7d70db28924f29bce55b55f567d8053f2/synapse/crypto/context_factory.py#L130-L139
I'm not sure if there's a way to provide a default value to
getboolean, so I've added a check for it. The setup of the config file is that the default values are supposed to be put at the top, and then overridden later on in the config file, but that all seems pretty flaky. The whole config file needs a refactor which is tracked at #101.