Add a note to the federation invite endpoints that invites can be sent twice #2067
Conversation
…t twice As this may be non-obvious when implementing behaviour that is triggered by an incoming invite event. See #2062 for more context.
There was a problem hiding this comment.
Regarding the discussion in #2062, I actually saw this endpoint only as a request from the inviting homeserver to the invited homeserver to sign the event, not that it should have other side effects. But it's true that the description is vague and doesn't actually say what should happen on the invitee's side.
As a side note, it is also not clear in which order the signatures are applied here. Should the event already have the signature from the inviting homeserver? It would make sense that the invited homeserver checks the signature before signing it itself. The text doesn't say anything about it, and the definitions don't include a signatures field in the request (or the response for that matter), but the data has an example of a request with the signatures field (which appears in #2076).
|
|
||
| Also note that if the remote homeserver is already in the room, it will receive the | ||
| invite event twice; once through this endpoint, and again through a [federation | ||
| transaction](https://spec.matrix.org/v1.13/server-server-api/#transactions). |
There was a problem hiding this comment.
| transaction](https://spec.matrix.org/v1.13/server-server-api/#transactions). | |
| transaction](/server-server-api/#transactions). |
Otherwise it will always point to that spec version
|
|
||
| Also note that if the remote homeserver is already in the room, it will receive the | ||
| invite event twice; once through this endpoint, and again through a [federation | ||
| transaction](https://spec.matrix.org/v1.13/server-server-api/#transactions). |
There was a problem hiding this comment.
| transaction](https://spec.matrix.org/v1.13/server-server-api/#transactions). | |
| transaction](/server-server-api/#transactions). |
Synapse's implementation of |
It has to have a side-effect, at least in the case where the invited homeserver is not already in the room: the server must tell the user they have been invited and allow them to join the room if they wish. |
Ah right, sorry for the noise then. |
As this may be non-obvious when implementing behaviour that is triggered by an incoming invite event.
See #2062 for more context. Closes #2062.
Preview: https://pr2067--matrix-spec-previews.netlify.app