fix(sdk): Add m.room.create to bump_event_types for sliding sync
#3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the `rev` of our `ruma`'s fork to match the latest commit of our `feat-sss` branch, see ruma/ruma@f25b322. It adds `m.room.create` in the `bump_event_types` of a `v4::SyncRequestList` (equivalent of a `v5::request::List`).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
==========================================
- Coverage 84.01% 84.00% -0.01%
==========================================
Files 260 260
Lines 26700 26700
==========================================
- Hits 22432 22430 -2
- Misses 4268 4270 +2 ☔ View full report in Codecov by Sentry. |
andybalaam
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
revof ourruma's fork to match the latest commit of ourfeat-sssbranch, seeruma/ruma@f25b322. It adds
m.room.createin thebump_event_typesof av4::SyncRequestList(equivalent of av5::request::List).