Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movies offset #24

Closed
JuacOHI opened this issue May 18, 2024 · 4 comments · Fixed by #25
Closed

Movies offset #24

JuacOHI opened this issue May 18, 2024 · 4 comments · Fixed by #25
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JuacOHI
Copy link

JuacOHI commented May 18, 2024

Hello. How are you doing ? First of all, thanks for creating this tool of mass sync.

Im having an issue with this tool, i had to restart my computer and i used the -offset to skip the ones that i already synced, but it seems that it didn't work. Is this option working?. Here is a screenshot: https://imgur.com/a/PGWc4fc
bazarr-bulk

You can tell that my library its on the big side, almost 6000 and each one has 4 different languages, so if i resync everything its gonna take me a lot of days.

Thanks again for the tool.

@mateoradman mateoradman self-assigned this May 18, 2024
@mateoradman mateoradman added the bug Something isn't working label May 18, 2024
@mateoradman mateoradman added this to the v0.1.5 milestone May 18, 2024
@mateoradman
Copy link
Owner

Hi @JuacOHI, thanks for reporting the problem. I will test the feature again, and report back as soon as possible.

@mateoradman
Copy link
Owner

I've investigated this problem, and it seems that Bazarr's API only respects the start query parameter (I call it offset) in combination with the length query parameter (I call it limit). When start is set, but length is not, Bazarr sets length to -1 which retreives all results regardless of the start query param. I managed to come up with a workaround for this problem which does the following:

  • if offset is set, but limit is not set, set limit to max unsigned 32-bit integer (4294967295).

mateoradman pushed a commit that referenced this issue May 18, 2024
…ry param to MAX unsigned 32-bit integer instead of -1.
mateoradman added a commit that referenced this issue May 18, 2024
#24: force Bazarr API to respect the offset by setting the length que…
@JuacOHI
Copy link
Author

JuacOHI commented May 18, 2024

Thank you for the quick reply and solution.
I tried with the max integer and didn't work, but it did work when i put the limit number with the total of my library

bazarr-bulk
bazarr-bulk2

@mateoradman
Copy link
Owner

Thank you for the quick reply and solution.

I tried with the max integer and didn't work, but it did work when i put the limit number with the total of my library

bazarr-bulk

bazarr-bulk2

Thank you for the confirmation. An official fix for this problem is going to be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants