applets/wncklet/wayland-backend: Add basic context menu #1276
Conversation
There was a problem hiding this comment.
On a test build of this, the build and installation went fine, and things worked normally on Xorg.
I then tried to get the panel running on my (very old) wayfire install, which used to work but now errors out on trying to launch the panel. With or without the xorg mate-session running made no difference, I got this error from dbus on trying to run the panel under wayfire, which I doubt has anything to do with this PR:
** (mate-panel:19455): WARNING **: 12:53:05.092: Cannot register the panel shell: Error spawning command line “dbus-launch --autolaunch=0caba25203a261b01af20e4e0000040f --binary-syntax --close-stderr”: Child process exited with code 1
Thus I am not now able to test this, and I don't know how to debug that error from dbus or wayfire.
|
The wayland implementation of mate panel (or really any other kind of panel) requires wlr-layer-shell support to work in a meaningful way like docking to the top / bottom + applets have to be built in-process. It's quite possible your version of wayfire doesn't implement either of those. |
|
layer-shell is used in the version of wayfire I have (build Jan 2021) but there might have been too many changes since then. No time at the moment to rebuild all of it from scratch. Note that I have always built all the possible applets in-process and am quite familiar with that issue |
There was a problem hiding this comment.
I have finally gotten mate-panel to work in wayfire again. Still get the dbus-launch problem on starting in a separate vt on wayfire, but now wayfire can be run with x11 as a backend, giving you wayland inside the terminal, sort of like x11-wayland in reverse. In this mode, mate-panel will run, and I get a functional context menu with this.
For all that, the context menu renders, it renders in the right place, and maximize, unmaximize, minimize, and close all work. The option to close windows by middle click does not work, but that's separate from the context menus and is for another PR
Add a basic shared context menu.
I could only verify 'close' on sway because it doesn't support set_minimize or set_maximize but they should work just fine.
This is my first time doing anything with GTK so please verify g_new0 / gtk_widget_destroy / g_free is working as intended and it neither leaks memory nor tries to access free'd memory.