-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FetchResult#toPromise #132
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…you need to access the context
…ruth for type system
Replace underscore with lodash in v0.9
Better error handling
Improve warning messages
(De)hydrate Store#fetchHistory
Support dataType and contentType
Add CookieStateSource
You can't change the branch a PR merges into so moving this to #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases when you want to consume a fetch result outside of a component we want to be able to transform a FetchResult into a promise. FetchResults know their Id and what store they came from but stores won't tell us when a fetch changes (only when the store state changes). To get around this I suggest we add
Store#addFetchChangedListener()
which calls any listeners just before a fetch result is returned.Resolves #131
To do
toPromise
should still work if we don't pass in an Id/store