best-deep alias broken #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The best-deep alias in marian is currently broken, because it doesn't set the model type and the default is `amum` which is incompatible with multiple layers. This commit just adds the type to the best-deep alias entry.
snukky
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thank you. It seems that --type s2s was required for --best-deep since forever, so that's a nice usability improvement. I think none of the regression tests should be affected, I found only one that tests best-deep but it already sets --type s2s: https://github.com/marian-nmt/marian-regression-tests/blob/7d612ca5e4b27a76f92584dad76d240e34f216d0/tests/interface/config/test_alias_best_deep.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The best-deep alias in marian is currently broken, because it doesn't set the model type and the default is
amumwhich is incompatible with multiple layers. This commit just adds the type to the best-deep alias entry.List of changes:
type: s2sto the--best-deepalias entry.Added dependencies: none
How to test
Try to train a
--best-deepmodel with a bare minimum config.Checklist