Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory listing in Ubuntu and macOS workflows #938

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

graemenail
Copy link
Member

@graemenail graemenail commented Jun 3, 2022

Description

The windows workflow includes a directory listing of the executables. This PR adds the same to the Ubuntu and macOS workflows. Perhaps useful to check for any unforeseen increases in binary size (as in #937).

List of changes:

  • Adds ls command to Ubuntu & macOS workflows

Added dependencies: none

How to test

Ran on CI in fork

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md

@graemenail graemenail mentioned this pull request Jun 3, 2022
4 tasks
@graemenail graemenail marked this pull request as ready for review June 3, 2022 16:36
Copy link
Member

@snukky snukky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @graemenail

@snukky snukky merged commit e27da62 into marian-nmt:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants