Added pragma to ignore unused-private-field error on elementType_ #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch failed in macOS
|
Hi and thanks. |
|
Ping @emjotde. It's needed to compile on some Mac OS X. |
snukky
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added pragma to ignore unused-private-field error on elementType_ in expanded_gemm.h when compiling on macOS without USE_FBGEMM.
Added dependencies: none
How to test
Built using on macOS
cmake .. -DBUILD_ARCH=x86-64 -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCOMPILE_CPU=on -DCOMPILE_AVX=off -DCOMPILE_AVX2=off -DCOMPILE_AVX512=off -DUSE_SENTENCEPIECE=on -DUSE_APPLE_ACCELERATE=onRan unit tests which all passed and CPU regression tests which passed apart from:
Both looked like small translation differences from the log
Checklist