2024 rust edition #1719
Open
2024 rust edition #1719
+424
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think precommit has updated their ubuntu images, so this might be ready to go |
Apparently rollout for both GH and pre-commits' CI is slower than thought. |
nyurik
reviewed
Mar 4, 2025
| warn!("Environment variable {key} has invalid unicode. Lossy representation: {v}"); | ||
| None | ||
| } | ||
| Some(s) => match s.into_string() { |
There was a problem hiding this comment.
might be easier with .map_err(...).ok() ?
There was a problem hiding this comment.
maybe, but it would introduce a clone due to how the borrow checker currently works..
(happy to be proven wrong, could not get it to work out)
Lets keep it as is for now
Co-authored-by: Yuri Astrakhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Reverts #1718
This PR upgrades (
cargo fix --eddition, then fix what does not make sense) our crates to the 2024 edition.While quite early, this enables things such as the v3 resolver, which might be helpfull to prevent MRSV breakages in the future by a MSRV breakage now.
Most of the changes are from rustfmt => going commit-by-commit is likely a good approach
Depends on:
Update Rust to 1.85 (2024 edition) actions/runner-images#11637
1.85.0and rustup to1.28.0pre-commit-ci/runner-image#294