2024 rust edition #1698
Merged
2024 rust edition #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI working is depedent on the 2024 eddition getting to githubs CI..: |
nyurik
approved these changes
Mar 1, 2025
|
Why did this get automerged? |
|
In particular, we are missing this PR: |
CommanderStorm
added a commit
that referenced
this pull request
Mar 3, 2025
This reverts commit 1deeda8.
CommanderStorm
added a commit
that referenced
this pull request
Mar 3, 2025
Reverts #1698 I have no idea why this was automerged.. that was a mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades (
cargo fix --eddition, then fix what does not make sense) our crates to the 2024 edition.While quite early, this enables things such as the v3 resolver, which might be helpfull to prevent MRSV breakages in the future by a MSRV breakage now.
Most of the changes are from rustfmt => going commit-by-commit is likely a good approach