Wide line PoC (Metal Custom Layer) #2112
Conversation
for more information, see https://pre-commit.ci
…libre/maplibre-gl-native into mlncustomstylelayer-refactor
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…libre/maplibre-gl-native into mlncustomstylelayer-refactor
|
|
stefankarschti
changed the title
stefankarschti
requested review from
louwers,
cgalvan,
alexcristici,
mwilsnd,
TimSylvester and
sjg-wdw
Oh right, we need to address that. I own that code and I can grant whatever rights you want. What's the copyright for new MapLibre code look like? |
|
@sjg-wdw That would be great. This is the license for MapLibre Native: https://github.com/maplibre/maplibre-native/blob/main/LICENSE.md So the copyright specifically is Copyright (c) 2021 MapLibre contributors |
|
Stefan has my permission to change the copyright on those files to MapLibre contributors. Let me know if you need that permission in some other form. |
|
@stefankarschti Could you remove the copyright header, and then clarify with Steve that the following is true:
|
Yes, that's fine with me. I grant permission on behalf of mousebird consulting. |
| return { .valid = false }; | ||
| } | ||
|
|
||
| const float tA = (a0.x * a1.y - a0.y * a1.x); |
There was a problem hiding this comment.
Mostly the same shader source as before here? Refer to #2183 for previous nits I had in this shader.
| // Note that `inst[2].totalLen` wraps to zero at the end, and we don't want that. | ||
| // Texture coords are used for edge blending, so we need to set them up even if there are no textures. | ||
| float texY = 0; | ||
| float texX = 0; |
There was a problem hiding this comment.
It looks like texture support was removed from this shader, I see some texcoord manipulation commented out in a few places. Could you remove these references?
| struct TriWideArgBufferFrag { | ||
| UniformDrawStateA uniDrawState [[ id(WKSUniformDrawStateEntry) ]]; | ||
| UniformWideVec wideVec [[ id(WKSUniformWideVecEntry) ]]; | ||
| bool hasTextures; |
| } | ||
|
|
||
| struct TriWideArgBufferFrag { | ||
| UniformDrawStateA uniDrawState [[ id(WKSUniformDrawStateEntry) ]]; |
Implement wide line vectors as a Custom (raw) Metal layer by adapting code from WhirlyGlobe.