N-api (node-addon-api) #161
Merged
+669
−819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ../src/object_async/hello_async.cpp:137:1: error: 'object_async::HelloObjectAsync::name_' should be initialized in the member initialization list [-Werror=effc++] HelloObjectAsync::HelloObjectAsync(Napi::CallbackInfo const& info) ``` changes. Lines starting
This reverts commit 4df69fc.
+ formatting + use `override final`
…g::data with const_cast (clang-tidy)
…explicitely transfer ownership to keep clang-tidy happy (cppcoreguidelines-owning-memory)
This reverts commit eaa4fbf.
This reverts commit bd6bdb6.
…and default `OnOk()` and `OnError`.
… (e.g clang++ differs from GCC) + check `result_` before deref etc. C++ standard 5.2.2.8 : "The order of evaluation of arguments is unspecified. All side effects of argument expression evaluations take effect before the function is entered. The order of evaluation of the postfix expression and the argument expression list is unspecified." http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2005/n1905.pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::vector<char>to hold results of acpu-intensive-taskto avoidconst_cast(c++)AsyncHelloWorker_v2usingGetResultto pass results of an async op (impl style)gsl::ownerutility to express explicit transfer of a ownership (c++)