-
Notifications
You must be signed in to change notification settings - Fork 10
Support node v10x #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These can be fixed by following the guidelines at https://github.com/nodejs/nan/blob/master/doc/asyncworker.md#api_nan_async_queue_worker
|
Upgrade to [email protected] - refs #125
Start building for node v10 and v8 - refs #125
done with #144 |
Node v10 was released on Tuesday: https://nodejs.org/en/blog/release/v10.0.0/.
This is a big deal because node does not release even numbered major releases very often.
Supporting node v10 will require upgrading to the latest
nan
release.This means we'll need to deal with new v8/nan deprecations. Otherwise the builds will fail due to node-cpp-skel's use of
-Werror
and the new deprecations ofNan::MakeCallback
(https://github.com/nodejs/nan/blob/master/doc/node_misc.md#nanmakecallback)The deprecation errors look like:
The task ahead is to:
nan
and fix the deprecation warnings/errors (ex: Upgrade to [email protected] - refs #125 #127)Open question: should node-cpp-skel be testing, in its job matrix, both node v6, v8, and v10? These are all currently within the LTS window (https://github.com/nodejs/Release#release-schedule). Or should node-cpp-skel just test the latest LTS version (in this case, right now v10) to keep the matrix under control and assume that downstream users of node-cpp-skel will add support for the versions they need?
NOTE: alternatively node-cpp-skel can (and likely should soon) move to using N-API instead of
nan
, which would mean that we'd be able to stop building binaries for each node version as those binaries would be compatible across MAJOR versions (perhaps with a few gochas). This is tracked at #45.The text was updated successfully, but these errors were encountered: