Workaround webkit disrespecting e.preventDefault() #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
force-pushed
the
safari-grrrr
branch
from
ae84dec to
26736b8
Compare
anandthakker
force-pushed
the
safari-grrrr
branch
from
26736b8 to
927fb9c
Compare
|
Let's just bind both |
jfirebaugh
reviewed
Apr 3, 2018
src/ui/bind_handlers.js
Outdated
| // Bind touchmove with passive: false on iOS because, even though | ||
| // onTouchMove only fires a map event, binding with passive: true causes | ||
| // iOS not to respect e.preventDefault() in _other_ handlers, even if they | ||
| // are non-passive. https://bugs.webkit.org/show_bug.cgi?id=182521 |
There was a problem hiding this comment.
Is this the right WebKit bug URL?
There was a problem hiding this comment.
Whoops, I must have copied from the wrong tab, thanks.
anandthakker
force-pushed
the
safari-grrrr
branch
from
927fb9c to
873c74d
Compare
|
@jfirebaugh updated |
jfirebaugh
approved these changes
Apr 3, 2018
src/ui/bind_handlers.js
Outdated
| DOM.addEventListener(el, 'touchstart', onTouchStart, {passive: false}); | ||
| DOM.addEventListener(el, 'touchmove', onTouchMove, {passive: true}); // `passive: true` because onTouchMove only sends a map event. | ||
| DOM.addEventListener(el, 'touchmove', onTouchMove, {passive: false}); | ||
|
|
||
| DOM.addEventListener(el, 'touchend', onTouchEnd); // The real action is in DragPanHandler and TouchZoomRotateHandler. |
There was a problem hiding this comment.
You can remove the comment here.
anandthakker
force-pushed
the
safari-grrrr
branch
from
873c74d to
dcf2c86
Compare
anandthakker
added a commit
that referenced
this pull request
Apr 11, 2018
chrisvoll
added a commit
to seatgeek/mapbox-gl-js
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6248 to work around https://bugs.webkit.org/show_bug.cgi?id=182521